Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#9713 closed Patch - Bug Fix (Fixed)

Fix scaling of channel icons in recorded programs screen

Reported by: skd5aner <skd5aner@…> Owned by: mdean
Priority: minor Milestone: 0.25
Component: Plugin - MythWeb Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In the last few versions of MythWeb, the default recorded programs screen leveraged a "width" attribute in the <img> tag. This caused channel icons to scale correctly in 95% of cases where the width of the icon was larger or close to the same size as the height. However, in cases where the height of the channel icon was significantly larger than the width, the icon would scale to 70px wide, but still be very tall and distort the height of the row compared to other rows.

Simple HTML attributes in the <img> tag don't really do what we want as it doesn't take into account max scale of width or height. Also, CSS for max-width and max-height aren't properly reflected in IE6 and IE7. Doing some google searching, I found a solution that should work for all modern browsers and IE6/7.

Attached is a patch which removes HTML attribute and changes it to leverage CSS. The patch fixes all current skins (include adding some css files in skins missing them). The patch was made against 0.24-fixes, but I believe it should apply cleanly to master. Tested in IE8, IE9, Chrome 10, and Firefox 4.

Attachments (2)

MythWeb-ChannelIconEdits.diff (3.9 KB) - added by skd5aner <skd5aner@…> 3 years ago.
MythWeb-ChannelIconEdits-v2.diff (5.6 KB) - added by skd5aner <skd5aner@…> 3 years ago.
Version 2 - additional tweaks

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by skd5aner <skd5aner@…>

Changed 3 years ago by skd5aner <skd5aner@…>

Version 2 - additional tweaks

comment:1 Changed 3 years ago by skd5aner <skd5aner@…>

Uploaded v2 of the patch - minor changes to keep row height for each show consistent regardless of icon height (or lack of icon).

comment:2 Changed 3 years ago by wagnerrp

  • Status changed from new to assigned

comment:3 Changed 3 years ago by mdean

  • Milestone changed from unknown to 0.25
  • Resolution set to Fixed
  • Status changed from assigned to closed

In a5bc3484f:

Use CSS to handle channel icon sizing.

Signed-off-by: Michael T. Dean

Closes #9713.

comment:4 Changed 3 years ago by mdean

  • Owner changed from kormoc to mdean

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.