Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#9902 closed Patch - Feature (fixed)

A few mythtranscode enhancements

Reported by: mythtv@… Owned by: beirdo
Priority: minor Milestone:
Component: MythTV - Mythtranscode Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no


The problems addressed:

1) In fifodir mode, mythtranscode refuses to run on remote files.

2) There is no indication of the format of the data output to the fifos; a user has to use a separate program to analyse the source file (possibly unreliable and not possible for remote files).

I have patches to address each. The first patch just alters the test for whether remote files can be transcoded. The second outputs details of what will be output to the fifos (accounting for use of the new --passthrough mode). The second patch also adds a --fifoinfo flag that can be used to get the format details printed out without actually performing the transcode.

The patches are committed to my github fork: There are versions of the patches on each of the branches: master, fixes/0.24 and jyavenard/backports/fixes/0.24. Those are the only patches I have currently added to those branches.

I'm happy to put more work into the patches to address any objections as to style etc.

Change History (7)

comment:1 Changed 10 years ago by beirdo

Owner: set to beirdo
Status: newassigned
Type: Bug Report - GeneralPatch - Feature

comment:2 Changed 10 years ago by mythtv@…

Forgot to say before: the version on master is untested, other than checking it builds. The two versions on the branches have been tested - in case that helps.

comment:3 Changed 10 years ago by beirdo

Component: MythTV - GeneralMythTV - Mythtranscode

comment:4 Changed 10 years ago by beirdo

Not sure I like the use of cout, particularly in master. I'd like to keep the use of that to only things that are CLI-driven, and allow the information to be logged rather than just be on the console. This will obviously affect any scripts or anything that attempt to automatically use the output.

I have converted it to using the logs for master, and will likely do so for 0.24 backport version as well. Just trying to get the program to cleanly close.

comment:5 Changed 10 years ago by Github

Milestone: unknown0.25
Resolution: fixed
Status: assignedclosed

Merge branch 'glidos-master'

Fixes #9902.

This adds a --fifo-info command-line argument to mythtranscode, and also allows for remote transcoding when running in fifo mode. Additionally, the shutdown of mythtranscode has been tidied up by using a CleanupGuard? that matches that of mythcommflag and other binaries.

Branch: master Changeset: f40668e2f2014f2101a420cfaead59525d90983b

comment:6 Changed 10 years ago by beirdo


Merged into fixes/0.24 in a466843d2ab2f4b4971a4a6f380f4469bedc0e95

comment:7 Changed 9 years ago by stuartm

Milestone: 0.24.2

Milestone 0.24.2 deleted

Note: See TracTickets for help on using tickets.