Opened 13 years ago
Closed 13 years ago
Last modified 12 years ago
#9917 closed Patch - Bug Fix (fixed)
softblend OSD is displayed with wrong colors on powerpc
Reported by: | Owned by: | beirdo | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | MythTV - Video/OSD Rendering | Version: | Unspecified |
Severity: | medium | Keywords: | ppc |
Cc: | Ticket locked: | no |
Description
Due to an endianness problem, components of the YUVA image are mixed up, which causes the OSD to be displayed wrongly (usually all red/pink). The trivial fix is to change:
mythtv/libs/libmythtv/util-osd.cpp, line 246:
b1 = src1 + B_OI; b2 = b1 + 4; b3 = src2 + 0; b4 = b3 + 4; g1 = src1 + G_OI; g2 = g1 + 4; g3 = src2 + 1; g4 = g3 + 4; r1 = src1 + R_OI; r2 = r1 + 4; r3 = src2 + 2; r4 = r3 + 4; a1 = src1 + A_OI; a2 = a1 + 4; a3 = src2 + 3; a4 = a3 + 4;
into
b1 = src1 + B_OI; b2 = b1 + 4; b3 = src2 + B_OI; b4 = b3 + 4; g1 = src1 + G_OI; g2 = g1 + 4; g3 = src2 + G_OI; g4 = g3 + 4; r1 = src1 + R_OI; r2 = r1 + 4; r3 = src2 + R_OI; r4 = r3 + 4; a1 = src1 + A_OI; a2 = a1 + 4; a3 = src2 + A_OI; a4 = a3 + 4;
Changing this fixes the OSD display problem on linux ppc. Version 0.24, 0.24.1 and git head are affected.
Change History (4)
comment:1 Changed 13 years ago by
Owner: | changed from markk to beirdo |
---|---|
Status: | new → assigned |
comment:2 Changed 13 years ago by
Milestone: | unknown → 0.25 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Fix endian issue in OSD color conversion
Fixes #9917
There were already defines available that were setup by endian, just not consistently used.
Signed-off-by: Gavin Hurlbut <ghurlbut@…>
Branch: master Changeset: d8a67ef62c21e23c9ab3a37fa80cc204bc8db14c
comment:3 Changed 13 years ago by
Milestone: | 0.25 → 0.24.2 |
---|
Backported to fixes/0.24 as be29d21c2b13e62de86b
Giving this to you, unless you know if any other dev runs a Linux PPC machine to test on.