Opened 13 years ago

Closed 13 years ago

#9960 closed Patch - Bug Fix (Fixed)

[PATCH] logging: fix unbalanced mutex unlock

Reported by: Lawrence Rust <lvr@…> Owned by: beirdo
Priority: minor Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: medium Keywords: logging mutex assert
Cc: Ticket locked: no

Description

commit df84a066070 caused an unbalanced mutex lock/unlock in DBLoggerThread::run

Please can all devs build and test against a debug build of Qt. The debug build has extensive runtime checking to find these problems and produce an informative ASSERT and backtrace. This bug ASSERTs within the 1st second after starting the backend.

Attachments (1)

0001-logging-fix-unbalanced-mutex-unlock.patch​ (1.0 KB) - added by Lawrence Rust <lvr@…> 13 years ago.

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by Lawrence Rust <lvr@…>

Attachment: 0001-logging-fix-unbalanced-mutex-unlock.patch​ added

comment:1 Changed 13 years ago by beirdo

Owner: set to beirdo
Status: new → assigned

This is being reworked in another ticket right now.

comment:2 Changed 13 years ago by danielk

I've reviewed Lawrence's fix and it's correct. I'm not applying yet since I haven't heard back from a ping to beirdo as to the other ticket.

comment:3 Changed 13 years ago by danielk

Fixed in [b7c4e81bca63]. Thanks Lawrence! I can't believe I committed that code, embarrassing.

comment:4 Changed 13 years ago by beirdo

Milestone: unknown → 0.25
Resolution: → Fixed
Status: assigned → closed

Thanks, danielk. The other one I was referring to was #5501 with the nice large patch, but I'm glad this was fixed in the meantime.

Note: See TracTickets for help on using tickets.