Modify ↓

Ticket #10705 (closed Bug Report - General: fixed)

Opened 13 months ago

Last modified 12 months ago

Spurious "Response too short" messages

Reported by: Ian Dall <ian@…> Owned by: mdean
Priority: minor Milestone: 0.25.1
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

PlaybackSock::GetMaxBitrate() expects 2 tokens in the reply but only one is sent. This error also results in a default value being used for max bitrate instead of the value reported by the slave backend.

Attachments

get_max_bitrate.diff​ (616 bytes) - added by Ian Dall <ian@…> 13 months ago.
Patch to expect correct response from GET_MAX_BITRATE

Change History

Changed 13 months ago by Ian Dall <ian@…>

Patch to expect correct response from GET_MAX_BITRATE

comment:1 Changed 12 months ago by mdean

In 69118953b:

Fix PlaybackSock::GetMaxBitrate? protocol usage.

QUERY_REMOTEENCODER now returns only one value. This change was missed when the protocol was changed to send 64-bit values directly, instead of encoded as two 32-bit ints (this part, specifically, in 1508085eb3 ).

comment:2 Changed 12 months ago by Ian Dall <ian@…>

  • Owner set to Ian Dall <ian@…>
  • Status changed from new to closed
  • Resolution set to fixed

In 5c56d5bc4ddc44b04265cabb8048878833ad3eaf/mythtv:

Fix PlaybackSock::GetMaxBitrate? protocol usage.

QUERY_REMOTEENCODER now returns only one value. This change was missed
when the protocol was changed to send 64-bit values directly, instead of
encoded as two 32-bit ints (this part, specifically, in 1508085eb3 ).

Fixes #10705.

Signed-off-by: Michael T. Dean <mdean@…>

comment:3 Changed 12 months ago by mdean

  • Milestone changed from unknown to 0.25.1

Thanks for the patch, Ian!

comment:4 Changed 12 months ago by kenni

  • Owner changed from Ian Dall <ian@…> to mdean
View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.