JumpPoints don't work when OSD is present

[Jim Stichnoth <stichnot@…>]

JumpPoints? don't work properly when some OSD element is displayed while playing a recording or video. More generally, they don't work in a TV playback context when it would require more than one Escape keypress to exit TV playback. For example, pressing Pause and leaving the progress indicator up, or editing the cutlist, or adjusting the timestretch. This is a similar problem to ticket #7322.

This patch fixes the problem by providing a wrapper function around TV::ProcessKeypress?() which repeatedly pummels the system with Escape key events until it is beaten into submission and surrenders.

I originally wasn't going to bother with this, until I saw that using MythUI to draw the OSD has been pushed back to 0.24.

[Jim Stichnoth <stichnot@…>]

Updated patch to tv_jumppoints_v2.patch after [24623].

[Jim Stichnoth <stichnot@…>]

Updated to tv_jumppoints_v3.patch.

1. I just noticed that after the libmythui-osd branch merge, jumppoints aren't working during playback while an OSD Dialog is present, such as pressing "m" to bring up the menu. This patch fixes that.

2. I reorganized the code to eliminate the wrapper function for TV::ProcessKeypress?(), in order to keep the TV class unchanged. I didn't re-indent the old code, to prevent the patch from being dominated by whitespace differences.

[Jim Stichnoth <stichnot@…>]

Updated to the v4 patch. This just reflects the NVP renaming.

[Jim Stichnoth <stichnot@…>]

Updated to the v5 patch, which additionally stops executing a playlist when a jumppoint is executed.

[Jim Stichnoth <stichnot@…>]

The v7 patch makes jump points work correctly when using the new cutlist editor.

[anonymous]

What's the status of this patch? Is it possible to get this checked in on the 0.23.1 fixes branch? This bug is pretty annoying. Thanks!

[anonymous]

Replying to anonymous:

What's the status of this patch? Is it possible to get this checked in on the 0.23.1 fixes branch? This bug is pretty annoying. Thanks!

Trac is not the place for such comments. Please ask on the mythtv-dev mailing list.

[markk]

Jim - I understand that you're working on a different approach to this issue. I've tentatively set a 0.24 milestone with the more realistic expectation that it will probably get pushed back to 0.25

[robertm]

Bumping to .25 given the proximity of release and likely need to test the forthcoming solution.

[markk]

Jim - v8 of the patch is, as far as I can tell, still the same approach. Are you working on something else?

[sphery]

For better history tracking, the preferred approach mentioned in comment:10 and comment:12 is ​http://svn.mythtv.org/trac/ticket/7322#comment:5

See, also, ​http://www.gossamer-threads.com/lists/mythtv/dev/451835#451835 + ​http://www.gossamer-threads.com/lists/mythtv/dev/462730#462730 .

[sphery]

Oh, and once a proper approach is incorporated, we can remove the hacks currently in MythVideo? (#7322) and MythGallery (#8250).

[Jim Stichnoth <stichnot@…>]

Reverted the structure of the patch to use a wrapper function, to simplify the changes.

[sphery]

ref ​https://github.com/MythTV/mythtv/commit/47fbdc86b

Add a couple of additional functions to allow iterating over the screen stacks.

[Jim Stichnoth <stichnot@…>]

Change VERBOSE() to LOG().

[Jim Stichnoth <stichnot@…>]

Synch up to latest version of master

[Jim Stichnoth]

Simplified version.

[Jim Stichnoth]

Even simpler version

[Github]

Make jump points work during playback when the OSD is present.

This works by sending an EXIT_TO_MENU event at the start of jump point execution. Any existing TV playback instance will receive this message and manually shut down playback, including tearing down the OSD.

This is not the fully general solution desired, but it is a big improvement until then.

One issue is that an editing session is not shut down cleanly. That will be addressed in a subsequent commit.

Refs #7939

Branch: master Changeset: 307dac8776d54a5d104da1b8f8c046039ed1d143

[Github]

Exit cutlist edit mode cleanly when executing a jump point.

When the user executes a jump point in the middle of an editing session, make sure the edit session closes cleanly. The work is not explicitly saved, but the auto-save state is retained in the database so that it will be auto-loaded next time the user edits that program.

This makes a slight modification to the MythPlayer? class and therefore the binary version is bumped, so be sure to do everything that entails.

Refs #7939.

Branch: master Changeset: 9b5b7b514408f8b25052ee1c0bebc05e676efc1d

[Jim Stichnoth]

Closing as fixed since the original issue in the ticket has been addressed.

See #10407 for the overhaul of the jump point implementation.

[Jim Stichnoth]

Attempted back-port to 0.24. Compiles, but not tested. Combines 307dac8776d54a5d104da1b8f8c046039ed1d143, 343022203cdf6948428187e8f1fb6337ca7b0de0, and the last chunk of 9b5b7b514408f8b25052ee1c0bebc05e676efc1d .