Opened 8 years ago

Closed 7 years ago

#10125 closed Patch - Bug Fix (Won't Fix)

jamu.py incorrectly initialises series_name_override

Reported by: jamesremuscat@… Owned by:
Priority: minor Milestone: unknown
Component: MythTV - General Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In current 0.24-fixes head, jamu.py incorrectly initialises self.configseries_name_override? (expected to be an array) as a boolean.

Find attached a trivial patch that instead initialises it to an empty list.

I acknowledge that jamu.py is disappearing in v0.25 but in the meantime this might be useful to anyone who's noticed the hourly jamu run starting to spam their logs.

Attachments (1)

jamu.patch (1.1 KB) - added by jamesremuscat@… 8 years ago.
Patch to initialisation of series_name_override

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by jamesremuscat@…

Attachment: jamu.patch added

Patch to initialisation of series_name_override

comment:1 Changed 8 years ago by jamesremuscat@…

Apologies, I've filed this under the wrong component (my eyes misread "mythvideo" for "mythweb"); Trac doesn't seem to want me to change it though.

comment:2 Changed 8 years ago by r.d.vaughan@…

James,

This patch would not work consistently. Please attach an example of the "spam their logs". I am willing to correct the issue but am having problems reproducing the unwanted messages. FYI When there are values for "series_name_override" it is a dictionary "{}" and not a list "[]". There is code which would abort if "series_name_override" is initialized as a list.

comment:3 Changed 8 years ago by jamesremuscat@…

My system is set up to run jamu hourly - /etc/cron.hourly/mythtv-frontend calls

su mythtv -c "/usr/bin/python /usr/share/mythtv/mythvideo/scripts/jamu.py -MW >> '/var/log/mythtv/jamu.log' 2>&1"

This was consistently returning with an exit code of 1, and root@ my machine was receiving hourly E-mail reports that

run-parts: /etc/cron.hourly/mythtv-frontend exited with return code 1

And in /etc/syslog:

Oct 26 21:17:01 basilisk CRON[7702]: (root) CMD ( cd / && run-parts --report /etc/cron.hourly) Oct 26 21:17:02 basilisk CRON[7701]: (CRON) error (grandchild #7702 failed with exit status 1)

comment:4 Changed 8 years ago by r.d.vaughan@…

Actually the output from "/var/log/mythtv/jamu.log" would tell me more than the exit code. I would like to determine why the exit code is "1" and I hope the "/var/log/mythtv/jamu.log" provides the answer.

comment:5 Changed 8 years ago by beirdo

Component: Plugin - MythWebPlugin - MythVideo
Owner: changed from Rob Smith to robertm

comment:6 Changed 8 years ago by robertm

Component: Plugin - MythVideoMythTV - General
Owner: robertm deleted
Status: newassigned

comment:7 Changed 7 years ago by Raymond Wagner

Resolution: Won't Fix
Status: assignedclosed

I'm closing this one as MythTV has not shipped with JAMU in several releases.

Note: See TracTickets for help on using tickets.