Opened 14 years ago
Closed 12 years ago
Last modified 12 years ago
#10142 closed Patch - Bug Fix (fixed)
Prevent PHP warning in upcoming.php due to wrong datatype in foreach
| Reported by: | Owned by: | Rob Smith | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.27 |
| Component: | Plugin - MythWeb | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | yes |
Description
At /tv/upcoming I get the following PHP warning:
Warning at /usr/share/mythtv/mythweb/modules/tv/upcoming.php, line 96: !NoTrans: Invalid argument supplied for foreach()!!
Warning at /usr/share/mythtv/mythweb/modules/_shared/tmpl/default/header.php, line 16: !NoTrans: Cannot modify header information - headers already sent by (output started at /usr/share/mythtv/mythweb/includes/errors.php:150)!!
It seems that the code tried to prevent that, but somehow it didn't get a full fix ($scheduled is unused). Trivial patch attached.
I am running 0.24.1 here, but it seems that the code is the same in the git master.
Attachments (3)
Change History (17)
Changed 14 years ago by
| Attachment: | mythweb-php-warning.patch added |
|---|
Changed 14 years ago by
| Attachment: | mythweb-php-warning-pt2.patch added |
|---|
comment:1 Changed 14 years ago by
I just found that detail.php has the same problem; I hope it's ok to add this to this bug report, otherwise I'm happy to open a new one or attach an combined patch if that's easier for you.
comment:2 Changed 13 years ago by
Has this bug been fixed...? Tryed to change my php files but they couldend load after change.
comment:3 Changed 13 years ago by
No, as far as I know the patches have not been applied. I have no idea how the process to get a patch applied is supposed to work in MythTV.
comment:6 Changed 13 years ago by
| Ticket locked: | unset |
|---|
Unlocking to allow uploading another patch. Please keep discussion out of the bug tracker so we don't have to lock the ticket, again.
Changed 13 years ago by
| Attachment: | 0001-fix-findSchedules-returning-undefind-as-array.patch added |
|---|
comment:7 Changed 13 years ago by
Hi, The problem occurred in my new 12.04 installation today. The "fix" listed here does not correct the problem that I have. Of course it takes care of the web error, but it does not solve the real problem. It hides it. What I see is that scheduling does not work at all. I can see from the list that there are programs that the scheduler should find but it doesn't. Even the programs that were part of the scheduled recordings (visible yesterday) have disappeared. I have all the latest updates installed. Please advice if I should retrieve any information from a log.
comment:8 Changed 13 years ago by
Update... After I cleaned out some bad recordings, removed some unwanted custom schedules, added the fix and rebooted the scheduler seemed to come alive again...
comment:9 Changed 13 years ago by
comment:10 Changed 13 years ago by
Hi,
as this bug kills the scheduler and pretty much renders MythTV useless, I suggest to change the priority to critical and get the fix released.
The issue seems to occur whenever EPG data is missing from a channel, which is a common situation.
I had to re-install 12.04 because it crashed terminally, and now I have again run into this bug. So, please get this patch released.
comment:11 Changed 13 years ago by
| Ticket locked: | set |
|---|
There's no way this bug could have killed your OS...and as stated before, please keep disussions (and posts which add no value to the report), out of the report.
comment:13 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:14 Changed 12 years ago by
| Milestone: | unknown → 0.27 |
|---|
Fixing same problem in detail.php