Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#10234 closed Bug Report - General (Invalid)

New Metadata screens break schedule recording on oldish themes

Reported by: mythtv.hook@… Owned by: stuartm
Priority: critical Milestone: unknown
Component: MythTV - User Interface Library Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Im not quite sure which component this should sit in, it may fit into one of three different areas: 'UI', 'Themes' or 'Scheduling', please feel free to move.

The new metadata section on the ScheduleEditor? is prohibiting users with older themes from being able to use MythTV to add/change schedules.

Error Given: 2012-01-03 02:16:07.222753 E Container 'ScheduleEditor?' is missing child 'metadata' 2012-01-03 02:16:07.222794 E ScheduleEditor?, theme is missing required elements

While I can see the benefits to this, instead of being required, can this default like screens do, or stop just the metadata screen working rather than the whole Schedule Editor.

Otherwise this breaks backward compatibility with the very nice themes that were developed for 0.24 (so far only Terra is working for me), and doesn't provide a good look to future themers.

Change History (2)

comment:1 Changed 8 years ago by robertm

Resolution: Invalid
Status: newclosed

This item has been added to all themes we control, and several third party themes, and has been there for many months. Either your themes are very out of date, or you are using third party themes. If you are using third party themes, it is the responsibility of the theme author to keep the theme up to date for use with new versions. All themes with code in the mythtv repository (as well as, minimally, the newest available versions of Arclight and Graphite) possess this required element.

comment:2 Changed 8 years ago by mythtv.hook@…

That response raises a number of other issues:

  • http://www.mythtv.org/wiki/Schedule-ui.xml#The_.22scheduleeditor.22_window states that the metadata option is not required (which is backward compatible with all existing 0.24 themes)
  • The version of Graphite (25.1) and other themes available in the theme downloader are not up to date (I tested them before originally submitting this ticket, and again just now)
  • The theme downloader lists themes which do not have support for metadata

Heres the patch to scheduleeditor.cpp which makes metadata optional and as such allow all existing themes to be backward compatible:

diff --git a/mythtv/programs/mythfrontend/scheduleeditor.cpp b/mythtv/programs/mythfrontend/scheduleeditor.cpp
index 07aa81a..0cbbad7 100644
--- a/mythtv/programs/mythfrontend/scheduleeditor.cpp
+++ b/mythtv/programs/mythfrontend/scheduleeditor.cpp
@@ -127,7 +127,7 @@ bool ScheduleEditor::Create()
     UIUtilE::Assign(this, m_postProcButton, "postprocessing", &err);
     UIUtilE::Assign(this, m_schedInfoButton, "schedinfo", &err);
     UIUtilE::Assign(this, m_previewButton, "preview", &err);
-    UIUtilE::Assign(this, m_metadataButton, "metadata", &err);
+    UIUtilW::Assign(this, m_metadataButton, "metadata");
 
     UIUtilE::Assign(this, m_cancelButton, "cancel", &err);
     UIUtilE::Assign(this, m_saveButton, "save", &err);

As I mentioned in the original ticket, I like the ability to choose metadata for recordings, but as it is the only change ive noticed that breaks existing themes it should be optional (or provided in another way)

Note: See TracTickets for help on using tickets.