Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#10235 closed Bug Report - General (Need more Info)

Compilation album is never detected

Reported by: mythtv@… Owned by: stuartm
Priority: minor Milestone: unknown
Component: Plugin - MythMusic Version: 0.24.1
Severity: medium Keywords: mythmusic compilation various artists
Cc: Ticket locked: no

Description

Hi,

due to a bug in metaioid3's function "*MetaIOID3::read" compilation albums are never detected.

In line 310 musicbrainz ALBUMARTIST_UUID is stored in "TStringToQString(musicbrainz->fieldList().back()))" and not in "TStringToQString(musicbrainz->fieldList().front()))" as in the source.

The correct paragraph is below:


    if (musicbrainz)
    {
        // If the MusicBrainz ID is the special "Various Artists" ID
        // then compilation is TRUE
        if (!compilation && !musicbrainz->fieldList().isEmpty())
            compilation = (MYTH_MUSICBRAINZ_ALBUMARTIST_UUID
            == TStringToQString(musicbrainz->fieldList().back()));
    }

This patch is tested and works.

Christian

Change History (7)

comment:1 Changed 8 years ago by stuartm

There should be only one string field in that tag, hence front() should work. Can you dump all the fields and see what's being inserted before MYTH_MUSICBRAINZ_ALBUMARTIST_UUID?

Which application was the tagging done in? Mythmusic/Picard/Other??

If some apps are sticking other text in the field it could appear after the UUID as well in which back() would break it for others. We could iterate over all fields checking each but if it's mythmusic inserting the bad data then we should fix that instead.

comment:2 Changed 8 years ago by paulh

Owner: changed from paulh to stuartm
Status: newassigned

comment:3 Changed 8 years ago by paulh

Status: assignedinfoneeded

comment:4 Changed 8 years ago by stuartm

Resolution: Need more Info
Status: infoneededclosed

comment:5 in reply to:  4 Changed 7 years ago by okuehn@…

Replying to stuartm: I'm facing the same issue and can reproduce with both, file being tagged by mythmusic during import or tagged by app mp3tag. Which additional debug information would be helpful?

Oliver

comment:6 Changed 6 years ago by Paul Harrison <pharrison@…>

In 6530ac633300a32c76db0d10cf8d107aa712a62c/mythtv:

MythMusic: Fix detection of compilations using special MusicBrainz? Artist ID

Look at all the fields in the 'TXXX=MusicBrainz? Album Artist Id' frame for the special
various artists ID not just the first one which in current version of the taglib
contains the tags description.

Refs #10235.
Fixes #12000.

comment:7 Changed 6 years ago by Paul Harrison <pharrison@…>

In 4c12503a741c5e2fa199eac414e4bafe53d51c12/mythtv:

MythMusic: Fix detection of compilations using special MusicBrainz? Artist ID

Look at all the fields in the 'TXXX=MusicBrainz? Album Artist Id' frame for the special
various artists ID not just the first one which in current version of the taglib
contains the tags description.

Refs #10235.
Fixes #12000.

(cherry picked from commit 6530ac633300a32c76db0d10cf8d107aa712a62c)

Note: See TracTickets for help on using tickets.