Metadata Options aren't saved

[JYA]

Go into Manage Recordings -> Recording Rule

Select an item in the list (in my example, I use Bionic Woman) Go into the Metadata Options

A list of suggestions are shown, (selecting an item isn't possible as per bug #10343) Press Escape

in the TMDB/TVDB# field, enter the number as found on: ​http://thetvdb.com/?string=bionic+woman&searchseriesid=&tab=listseries&function=Search here I used 80370

Set the series number to 1 and episode number to 1

Select "Find Covert Art Online", select one of the result

Select "Find Fanard Online", select one of the result

Select "Find Banners Online", select one of the result

Select "Done" and finally "Save"

You go back to the list of all recordings. Selecting the one you've just edited, go back into "Metadata Options"

none of the new data you entered in the step above are remembered.

It seems changes are never changed

[Github]

Fix editing inetref/season/episode from the PBB.

When called from the PBB, the rule editor uses recinfo rather than the rec rule. The RecordingInfo? Inetref, Season and Episode were continually being filled into the UI even though changes were being saved. So, if a recorded program had an inetref, and you edited it from the PBB, that value would stubbornly refill the UI even though the rule itself was different. Conversely, calling the editor from one of the other screens like the rule editor would work fine because there was no associated RecordingInfo?, and everything was filled in from the RecordingRule?.

Unconditionally use the database recording rule value to fill in the UI, no matter where the rule editor is invoked from.

Fixes #10344.

Branch: master Changeset: db123034e322be6af5104063b044933693ad2d25