Opened 8 years ago

Closed 22 months ago

#10672 closed Developer Task (Won't Fix)

Maddening Video Metadata Save/Exit Behavior [patch]

Reported by: adiemus <mythtv@…> Owned by: stuartm
Priority: minor Milestone: 0.28.2
Component: MythTV - Video Library Version: 0.25-fixes
Severity: low Keywords: metadata editor return save exit root
Cc: Ticket locked: no

Description

Having recently upgraded from 0.21-fixes to 0.25-fixes, one of the things I was most excited about was getting useful metadata into my videos. However, I quickly found myself to the point of near rage at the metadata edit dialog's behavior of returning to the root of the video list when done editing a file, rather than returning to the file just edited. (Making editing multiple files take a *painfully* long time, even with a keyboard)

Attached is a patch that (mis-)uses the "save and restore video selection" logic to make save/exit-ing from the metadata edit dialog return to the video just edited.

I've tested it locally in list/browser/gallery modes, and they all seem to work. However, I'm very unfamiliar with myth's codebase, and I'm quite sure this need a good looking over. (I've noticed, for example, that in browser/gallery mode the file counts when returning from edit are wrong, until you move to a new video, though you do end up back on the correct video. I mostly use the list view and am fairly unfamiliar with the browser/gallery views so I didn't look into this further)

Hope this is at least marginally useful.

Attachments (2)

mythtv-video-metadata-editor-return-behavior.patch (8.1 KB) - added by adiemus <mythtv@…> 8 years ago.
Patch to return to the just edited file when exiting the video metadata edit dialog
mythtv-video-metadata-editor-return-behavior-update.patch (8.1 KB) - added by adiemus <mythtv@…> 7 years ago.
Updated patch for the current state of 0.25-fixes

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by adiemus <mythtv@…>

Patch to return to the just edited file when exiting the video metadata edit dialog

Changed 7 years ago by adiemus <mythtv@…>

Updated patch for the current state of 0.25-fixes

comment:1 Changed 7 years ago by beirdo

Component: MythTV - GeneralMythTV - Video Library

comment:2 Changed 7 years ago by beirdo

Milestone: 0.25.1unknown

Please do not set the milestone.

comment:3 Changed 7 years ago by stuartm

Milestone: unknown0.26
Owner: set to stuartm
Status: newaccepted

comment:4 Changed 7 years ago by Kenni Lund [kenni a kelu dot dk]

Milestone: 0.260.26.1

comment:5 Changed 7 years ago by stuartm

Milestone: 0.26.10.27
Type: Patch - Bug FixDeveloper Task

I think there is another, better way to do this using the update event stuff that I'm working on to fix the bookmark/watched status bug.

comment:6 Changed 6 years ago by paulh

Milestone: 0.270.28

comment:7 Changed 4 years ago by Stuart Auchterlonie

Milestone: 0.280.28.1

Moving unresolved tickets to next point release

comment:8 Changed 3 years ago by Stuart Auchterlonie

Milestone: 0.28.10.28.2

Moving remaining open 0.28.1 tickets to 0.28.2

comment:9 Changed 22 months ago by Stuart Auchterlonie

Resolution: Won't Fix
Status: acceptedclosed

Closing any remaining tickets for 0.28, if the issue persists, feel free to reopen and align to v29 or master

Note: See TracTickets for help on using tickets.