Opened 8 years ago

Closed 6 years ago

#10698 closed Patch - Bug Fix (fixed)

Frontend network control in 0.25 is asymmetric with respect to music jump point

Reported by: Gregory Moyer <moyerg@…> Owned by: paulh
Priority: minor Milestone: 0.27
Component: MythTV - General Version: 0.25-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In 0.24, the jump "playmusic" resulted in a location of "playmusic".

MythFrontend Network Control
Type 'help' for usage information
---------------------------------
# jump playmusic
OK
# query location
playmusic
# 

However, in 0.25, the same "playmusic" jump no longer returns the same location response.

MythFrontend Network Control
Type 'help' for usage information
---------------------------------
# jump playmusic
OK
# query location
playlistview
# 

This makes code for external libraries slightly more complicated. It is also a little less than intuitive for the user typing commands into the network control socket.

The attached patch adds "playlistview" as a synonym to "playmusic" to allow for symmetry between the jump and the resulting location, while not breaking anything or anyone expecting "playmusic" to work.

MythFrontend Network Control
Type 'help' for usage information
---------------------------------
# jump playlistview
OK
# query location
playlistview
# jump mainmenu 
OK
# jump playmusic
OK
# query location
playlistview
# 

Synonyms have been created in the past with other jump points (i.e. playbackbox and playbackrecordings), though I do not know the reasoning behind those.

Attachments (2)

mythfrontend-version.log (871 bytes) - added by Gregory Moyer <moyerg@…> 8 years ago.
frontend-nc-music-jump.patch (702 bytes) - added by Gregory Moyer <moyerg@…> 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Gregory Moyer <moyerg@…>

Attachment: mythfrontend-version.log added

Changed 8 years ago by Gregory Moyer <moyerg@…>

comment:1 Changed 6 years ago by stuartm

Milestone: unknown0.27
Owner: set to paulh
Status: newassigned

Paul, this looks like a very easy one to close.

comment:2 Changed 6 years ago by Gregory Moyer <moyerg@…>

Resolution: fixed
Status: assignedclosed

In fe642a21c5ce12cff9c968a58e5693b76c4debef/mythtv:

networkcontrol: add "playlistview" as a synonym to "playmusic" jump point

This allows for symmetry between the jump and the resulting location, while
not breaking anything or anyone expecting "playmusic" to work.

Fixes #10698.

Signed-off-by: Paul Harrison <pharrison@…>

Note: See TracTickets for help on using tickets.