Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#10710 closed Patch - Feature (fixed)

MythMusic immediately play songs from playlist editor

Reported by: trebor_s@… Owned by: paulh
Priority: minor Milestone: 0.27
Component: Plugin - MythMusic Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I read about some usability complains on the mailing list. One issue is that the songs that were added from the playlist editor are not played immediately. The user had to go to the playlist, select the song and press play.

Attached is a patch that adds new functionality. When the user is in the playlist editor screens and navigates through his collection he can now press PLAY. This will also add the albums or tracks to the playlist (same as pressing SELECT) but it will start playing the first of the newly added songs immediately.

Robert S

Attachments (4)

mythmusic_play_tracks_from_playlisteditor_tree.patch (2.9 KB) - added by trebor_s@… 12 years ago.
mythmusic_add_menu.patch (1.7 KB) - added by trebor_s@… 12 years ago.
Adds a menu to add/replace files and play them directly
mythmusic_keybinding_for_play.patch (1.2 KB) - added by trebor_s@… 12 years ago.
Use a keybinding for the functionality instead of play
patch.playbutton (4.1 KB) - added by mayfields@… 12 years ago.
Includes additional cases preventing segfault eg playlists

Download all attachments as: .zip

Change History (11)

Changed 12 years ago by trebor_s@…

comment:1 Changed 12 years ago by stuartm

Milestone: unknown0.26
Owner: set to stuartm
Status: newaccepted
Version: UnspecifiedMaster Head

Changed 12 years ago by trebor_s@…

Attachment: mythmusic_add_menu.patch added

Adds a menu to add/replace files and play them directly

Changed 12 years ago by trebor_s@…

Use a keybinding for the functionality instead of play

comment:2 Changed 12 years ago by mayfields@…

Segfaults when pressing defined key on playlists, smart playlists. These nodes don't have metadata associated and need to be treated differently. Requires additional cases such as:

if (mnode->getAction() == "playlists") 

Example patch attached, provides similar (but not identical) functionality.

Changed 12 years ago by mayfields@…

Attachment: patch.playbutton added

Includes additional cases preventing segfault eg playlists

comment:3 Changed 11 years ago by Kenni Lund [kenni a kelu dot dk]

Milestone: 0.260.27

comment:4 Changed 11 years ago by Paul Harrison <mythtv@…>

Resolution: fixed
Status: acceptedclosed

In fe13684b4d5d635a6fd930ab49358cdf9192c2de/mythtv:

MythMusic: immediately play songs from playlist editor when PLAY is pressed

When the playlist tree has focus and PLAY is pressed all the tracks below the
current node will be added to playlist and the first track will start playing.

Closes #10710.

comment:5 Changed 11 years ago by paulh

Owner: changed from stuartm to paulh

comment:6 Changed 11 years ago by warpme@…

Paul, Quick Q to fe13684b4d5d635a6fd930ab49358cdf9192c2de commit: for me it works OK any higher node that single song (album, dir with albums, etc). It is not working for single song. It this planned behaviour or rather bug ?

comment:7 Changed 11 years ago by Paul Harrison <mythtv@…>

In 3860342e3452ecc6db7dc487a2924cbb2601b1cc/mythtv:

MythMusic: extend the immediate play when PLAY is pressed to individual tracks

Refs #10710.

Note: See TracTickets for help on using tickets.