Opened 7 years ago

Closed 7 years ago

#10762 closed Patch - Feature (Fixed)

Patch for compile with clang in greedyh.asm

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by:
Priority: minor Milestone: unknown
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

On Linux x86_64 platforms with clang, the compiler appears to optimize out variables that are used in the assembly code(s) in the file greedyh.asm, resulting in the inability to link the codes. This patch adds in the used attribute hint to those variables (as is done for other variables).

Longer term, it might make sense to port the current xine sources, which appear to have different improvements to that code area, but that would be a larger effort since the calling parms have also changed. This is a "minimal" fix.

Since clang is not an officially supported compiler, I am creating this as a feature patch.

Env: clang/llvm 3.1 with mythtv git master

Thanks for your consideration.

Attachments (1)

greedyh.asm.patch (877 bytes) - added by Gary Buhrmaster <gary.buhrmaster@…> 7 years ago.
Patch file

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Attachment: greedyh.asm.patch added

Patch file

comment:1 Changed 7 years ago by Craig Treleaven <ctreleaven@…>

comment:2 in reply to:  1 Changed 7 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Replying to Craig Treleaven <ctreleaven@…>:

Does this fix the workaround in:

http://code.mythtv.org/cgit/mythtv/commit/?id=375d12e3f4ae916e26f982b3ecee0ced462767ce

Possibly. Since I do not have a MacOS X system (at all, let along to build/test with), it is just conjecture that it is related (but seems plausible).

comment:3 Changed 7 years ago by JYA

Resolution: Fixed
Status: newclosed

Wish I had seen this one sooner.. Fixed in 8f998ab17edb602b3bc8e38132074ce69eb4733c

Note: See TracTickets for help on using tickets.