Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#10872 closed Bug Report - General (fixed)

Recording Quality score invalid for intentional late starts, early ends

Reported by: danielk Owned by: danielk
Priority: blocker Milestone: 0.26
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When a user intentionally sets up a recording to start late or end early it gets marked as having poor quality and the recording is eligible for re-recording. Instead we should account for this in the RecordingQuality?() constructor and not count these start/end "gaps" against the recording.

Attachments (1)

10872-v2.patch (13.0 KB) - added by danielk 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by danielk

Owner: set to danielk
Status: newaccepted

comment:2 Changed 6 years ago by gigem

Daniel,

Stopping a recording early should also not count against the recording quality score.

Changed 6 years ago by danielk

Attachment: 10872-v2.patch added

comment:3 Changed 6 years ago by danielk

The idea in this patch is to track the intended recording start and end times in RecordingInfo?. So far this captures the start and end times from the scheduler, but we still need to update the desired recording end time when the user ends the recording early. And of course we need to test thoroughly once complete.

comment:4 Changed 6 years ago by danielk

Priority: minorblocker

comment:5 Changed 6 years ago by Daniel Thor Kristjansson <danielk@…>

Resolution: fixed
Status: acceptedclosed

In 07acf0e850d62d6c54cec498c675cc8f82d83d64/mythtv:

Fixes #10872. Use desired start and end times.

The recording quality measurement needs to know when a recording was
supposed to start and end to know how much is actually missing from
the recording. We used to use the scheduled start and end times for
this, but sometimes a recording is intentionally started late or ended
early. This captures that by tracking the 'desired' start and end point.
This is initially set by the scheduler using and pre and post roll
values, and if the user intentionally stops a recording early that
updates the desired end time as well.

comment:6 Changed 6 years ago by danielk

Resolution: fixed
Status: closednew

This shouldn't have been marked fixed yet.

comment:7 Changed 6 years ago by Daniel Thor Kristjansson <dkristjansson@…>

In dc09143852e560266e8454ed9854705c87f330b9/mythtv:

Refs #10872. Use desired start and end times for recording quality.

This is the rest of [07acf0e85]. The constructors weren't right in
the previous commit and we need to get updated desired times to
the recorder for the recording quality determination to use them.

comment:8 Changed 6 years ago by Daniel Thor Kristjansson <danielk@…>

Resolution: fixed
Status: newclosed

In ecc1525d83abfed452e3b5f983de7c593063af91/mythtv:

Fixes #10872. Use desired start and end times.

The recording quality measurement needs to know when a recording was
supposed to start and end to know how much is actually missing from
the recording. We used to use the scheduled start and end times for
this, but sometimes a recording is intentionally started late or ended
early. This captures that by tracking the 'desired' start and end point.
This is initially set by the scheduler using and pre and post roll
values, and if the user intentionally stops a recording early that
updates the desired end time as well.

Conflicts:

mythtv/libs/libmythtv/dtvrecorder.h

comment:9 Changed 6 years ago by Daniel Thor Kristjansson <dkristjansson@…>

In 16231c959b2edbef011636e3c8df6e66933899e9/mythtv:

Refs #10872. Use desired start and end times for recording quality.

This is the rest of [07acf0e85]. The constructors weren't right in
the previous commit and we need to get updated desired times to
the recorder for the recording quality determination to use them.

Note: See TracTickets for help on using tickets.