Opened 12 years ago

Closed 12 years ago

#10968 closed Patch - Bug Fix (fixed)

Python bindings - MythTV.MythXML().getExpiring has wrong request URL

Reported by: esarfl@… Owned by: Raymond Wagner
Priority: minor Milestone: 0.26
Component: Bindings - Python Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

MythXML().getExpiring() seems to map to Dvr/GetExpiring, when the correct url is Dvr/GetExpiringList.

To reproduce, open a Python shell:

>>> import MythTV
>>> for i in MythTV.MythXML().getExpiring():
...   i
...   break
...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/pymodules/python2.7/MythTV/methodheap.py", line 1202,
in getExpiring
    for prog in self._request('Dvr/GetExpiring')\
  File "/usr/lib/pymodules/python2.7/MythTV/connections.py", line 574,
in readJSON
    return json.loads(self.read())
  File "/usr/lib/pymodules/python2.7/MythTV/connections.py", line 563, in read
    def read(self): return self.open().read()
  File "/usr/lib/pymodules/python2.7/MythTV/connections.py", line 562, in open
    def open(self): return urllib2.urlopen(self)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 406, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 519, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 444, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 527, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 404: Not Found

Attachments (1)

0001-Fix-request-url-in-python-bindings-MythXML-.getExpir.patch (969 bytes) - added by esarfl@… 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by esarfl@…

comment:1 Changed 12 years ago by Raymond Wagner

Milestone: unknown0.26

comment:2 Changed 12 years ago by Tom Hayward <esarfl+github@…>

Resolution: fixed
Status: newclosed

In e4c6e5db329007a6bbb5e890a3f402982fa03e29/mythtv:

Correct URL for MythXML.getExpiring()

This changes getExpiring() from using the incorrect "Dvr/GetExpiring?" to
the correct "Dvr/GetExpiringList?".

Fixes #10968

Signed-off-by: Raymond Wagner <rwagner@…>

Note: See TracTickets for help on using tickets.