Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 19 months ago

Closed 10 months ago

Last modified 10 months ago

#11138 closed Developer Task (fixed)

Mythweb still depends on DefaultStartOffset and DefaultEndOffset in 'settings'

Reported by: tycholursen@… Owned by: mdean
Priority: minor Milestone: 0.26.1
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Since 0.26 is out, I upgraded to it, including a fresh database.
I used to use the DefaultStartOffset? and DefaultEndOffset? vars in 'settings' to make sure I don't miss the beginning or end of a show.
Those settings are obsolete now, I use the default temlate in 'record' to accomplish the same goal.

While mythfrontend has adapted to this new situation, mythweb has not. It does not follow the new template in 'record'
So scheduling a show in mythweb will result in clipped shows, while scheduling a show for recording using mythfrontend is good.

I am using master branch from mythweb right now, as there is no fixes/0.26 yet.

When I insert the old values (DefaultStartOffset? and DefaultEndOffset?) in 'settings', mythweb will use that and recorded shows will start early and end late as I instructed.

Attachments (0)

Change History (7)

comment:1 Changed 19 months ago by bas-t <tycholursen@…>

Come to think of it, creating and editing templates should be part of mythweb too, since it is in mythfrontend as of fixes/0.26

comment:2 Changed 14 months ago by mdean

  • Owner changed from kormoc to mdean
  • Status changed from new to accepted

comment:3 Changed 10 months ago by Michael T. Dean <mdean@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In 71ee4dd6692a6ae9d99f9626459868f9863e30dc/mythweb:

Remove use of deprecated default rec rule settings

from MythWeb. These values should all be set from the recording rule
templates. Fixes #11138. Refs #11512.

comment:4 Changed 10 months ago by bas-t@…

Thanks a lot!

Could you backport this (and f97529656c) to fixes/0.26?

Regards,

Bas.

comment:5 Changed 10 months ago by paulh

  • Milestone changed from unknown to 0.27

comment:6 Changed 10 months ago by Michael T. Dean <mdean@…>

In 570f1375b0cefc5808653a57f861723dcc77db84/mythweb:

Remove use of deprecated default rec rule settings

from MythWeb. These values should all be set from the recording rule
templates. Fixes #11138. Refs #11512.

Backporting to 0.26 since there is no way to set the values being used
by MythWeb in 0.26.
(cherry picked from commit 71ee4dd6692a6ae9d99f9626459868f9863e30dc)

comment:7 Changed 10 months ago by mdean

  • Milestone changed from 0.27 to 0.26.1

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.