Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#11512 closed Patch - Feature (fixed)

PULL REQUEST: Add partial support for recording templates to mythweb

Reported by: mythtv@… Owned by: sphery
Priority: minor Milestone: 0.26.1
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When creating a new recording rule, merge in values from the Default recording template

Change History (9)

comment:1 Changed 12 years ago by mythtv@…

Forgot to add the url: ​https://github.com/MythTV/mythweb/pull/7

comment:2 Changed 12 years ago by Karl Egly

Owner: changed from Rob Smith to Karl Egly
Status: new → accepted

comment:3 Changed 12 years ago by sphery

Owner: changed from Karl Egly to sphery
Version: Unspecified → Master Head

comment:4 Changed 12 years ago by Michael T. Dean <mdean@…>

In 71ee4dd6692a6ae9d99f9626459868f9863e30dc/mythweb:

Remove use of deprecated default rec rule settings

from MythWeb. These values should all be set from the recording rule
templates. Fixes #11138. Refs #11512.

comment:5 Changed 12 years ago by Paul Gardiner <mythtv@…>

Resolution: → fixed
Status: accepted → closed

In f97529656ca2e7e4aa7806eb493873d72b2b7cef/mythweb:

Use Default recording rule template in MythWeb

when creating new recording rules. This patch only uses values from the
Default recording rule template, but it's still better/more capable than
the old approach that pulled values for a few parameters from settings.

Patch by Paul Gardiner (thanks!) with minor changes by me.
Fixes #11512.

Signed-off-by: Michael T. Dean <mdean@…>

comment:6 Changed 12 years ago by paulh

Milestone: unknown → 0.27

comment:7 Changed 12 years ago by Michael T. Dean <mdean@…>

In 570f1375b0cefc5808653a57f861723dcc77db84/mythweb:

Remove use of deprecated default rec rule settings

from MythWeb. These values should all be set from the recording rule
templates. Fixes #11138. Refs #11512.

Backporting to 0.26 since there is no way to set the values being used
by MythWeb in 0.26.
(cherry picked from commit 71ee4dd6692a6ae9d99f9626459868f9863e30dc)

comment:8 Changed 12 years ago by Paul Gardiner <mythtv@…>

In 8aa49039796ca347503553b048b5bd7a750df7c1/mythweb:

Use Default recording rule template in MythWeb

when creating new recording rules. This patch only uses values from the
Default recording rule template, but it's still better/more capable than
the old approach that pulled values for a few parameters from settings.

Patch by Paul Gardiner (thanks!) with minor changes by me.
Fixes #11512.

Signed-off-by: Michael T. Dean <mdean@…>

Backporting to 0.26 since users who upgraded from previous versions of
MythTV (and, therefore, had set the no-longer-existing settings) were
relying on their effect. This provides a functional replacement that
uses the proper approach for current MythTV.
(cherry picked from commit f97529656ca2e7e4aa7806eb493873d72b2b7cef)

comment:9 Changed 12 years ago by sphery

Milestone: 0.27 → 0.26.1
Note: See TracTickets for help on using tickets.