Changeset be8dd3067b broke working of DVB-C cam module

[gemma.daan@…]

In changeset be8dd3067b some "dead code" was commented out, unfortunately, this is not really dead code, as the "Tc->Poll()" method also makes sure the CAM module is working.

This changeset causes that encrypted channels can't be recorded any more.

            case stACTIVE:
                 if (!Tc->DataAvailable()) {
-                   if (Tc->Poll() != OK)
-                      ;//XXX continue;
+//                   if (Tc->Poll() != OK)
+//                      ;//XXX continue;
                    }
                 switch (Tc->LastResponse()) {

I reverted this change in my local test tree and tested it on my test machine, it restored the working of the CAM module.

[Daniel Kristjansson <danielk@…>]

In 40ff97370a7d7ad115c1f700131ff5464c34a484/mythtv:

Fixes #11298. Revert "Comment out dead code in dvbci.cpp to quiet clang++"

This code isn't as dead as I thought...

This reverts commit be8dd3067bdffcac651f5d00855105cbdfbe560f.

[Daniel Kristjansson <danielk@…>]

In a7e8f7f363939864ed4b1c971f807b8c24aa324d/mythtv:

Refs #11298. Print error message on Poll error.

[klaas.de.waal@…]

The error message added recently results in an endless stream of "E ERROR: Poll Error" messages, about 10 per second, in my otherwise correctly working system. The reason for this is that the "Tc->Poll()" method can also returns a value " != OK " when there is nothing wrong.
The way I understand it is that the function must be called and that the function value should be ignored. This is the way the code has been working in the last few years. Apparently the reason to change the code has been to remove compiler warnings. I think that to achieve this the function must not be called inside the "if" statement.
I will attach a trivial patch for this.

[klaas.de.waal@…]

Call Tc->Poll() outside if statement and ignore function value.

[Klass De Waal <klaas.de.waal@…>]

In 848e405d6c10ec9dcec360bb92b3485a2504129f/mythtv:

Call Tc->Poll() outside if statement and ignore function value.

Fixes #11298

Signed-off-by: Stuart Morgan <smorgan@…>
(cherry picked from commit 7c46e2ad254811c9210698f616e000aca749b035)

[Klass De Waal <klaas.de.waal@…>]

In faffb0f22be12c0405852f5ddccfa64b6f128049/mythtv:

Call Tc->Poll() outside if statement and ignore function value.

Fixes #11298

Signed-off-by: Stuart Morgan <smorgan@…>

[crazy.bombz@…]

Has this been fixed yet? My CAM is not working with 0.27 but worked fine as soon as I reverted to 0.26.