Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#11347 closed Patch - Bug Fix (fixed)

DVD playback sometimes flickers when jumping from a still to a video sequence.

Reported by: peper03@… Owned by: Jim Stichnoth
Priority: minor Milestone: 0.27
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Jumping from a still frame (or just allowing it to timeout) to a video sequence sometimes doesn't unpause video. This leads to bad flickering when the video buffers are forcibly drained. It appears that this only occurs under certain circumstances:

  • A video decoder in no additional buffering (i.e *NOT* VDPAU)
  • Still frame and video sequences in menu domains but not in cells marked as menus.
  • When the timing is right!

The flag 'dvd_stillframe_showing' was explicitly set to 'false' here, which prevents the check at the end of MythDVDPlayer::VideoLoop? from unpausing playback. The attached patch ensures MythPlayer::UnpauseVideo? is called at this point, matching the behaviour of the check at the end of the method.

See also the sample 'StillToVideoToMenu?.iso' in stuartm's DVD repository.

Attachments (1)

0001-Ensure-video-is-always-unpaused-when-jumping-from-a-.patch​ (1.0 KB) - added by peper03@… 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by peper03@…

Attachment: 0001-Ensure-video-is-always-unpaused-when-jumping-from-a-.patch​ added

comment:1 Changed 12 years ago by Jim Stichnoth

Milestone: unknown → 0.27
Owner: set to Jim Stichnoth
Status: new → accepted

comment:2 Changed 12 years ago by Richard <peper03@…>

Resolution: → fixed
Status: accepted → closed

In fcf176db6e06928364f35f32aa022696fb19edf6/mythtv:

Fix transitions from a DVD still frame into video. Fixes #11347.

Signed-off-by: Jim Stichnoth <jstichnoth@…>

comment:3 Changed 12 years ago by Richard <peper03@…>

In f35f899c79fa4769c7206948ea9612cc1d9adbd7/mythtv:

Fix transitions from a DVD still frame into video. Fixes #11347.

Signed-off-by: Jim Stichnoth <jstichnoth@…>
(cherry picked from commit fcf176db6e06928364f35f32aa022696fb19edf6)

Note: See TracTickets for help on using tickets.