Newlines in file.subtitle in recorded.php cause Javascript error (patch)

[Martin van Es <martin@…>]

When parsing mythweb/tv/recorded my (chrome and firefox) browsers throw an "Uncaught SyntaxError?: Unexpected token ILLEGAL" error on all file.subtitle strings containing newlines in the generated "Load the known shows" Javascript part. The result is I can't delete recordings.

My work-around is to encapsulate the line generating the file.subtitle string on line 300 with a string_replace and nl2br like this:

file.subtitle   = '<?php echo str_replace("\n", '', nl2br(addslashes($show->subtitle)))               ?>';

The nl2br replaces all newline variants to one <br />\n but the \n must disappear as well, so that's what the str_replace is for.

With this patch, the page loads succesfull and I can delete recordings again.

[bas-t@…]

The needed diff, according to Martin van Es

[Rob Smith]

Fixed in:

• 0.25 - dac091205e19f840b69df6e948f1ba44357dde1f
• 0.26 - e6747e6480294b0fc067d6d72d00a71937d3f7f8
• master - 2a6c2386324c1a7fb6901fc0ff82d43070447a1b