Current frame count in H.264 playback incorrect

[stuartm]

At some point in the last 2-3 weeks the calculation of current position in H.264 recordings from BBC One HD, BBC HD and possibly others in UK has significantly wrong.

For BBC HD it seems that every 8th frame is not counted toward the framesPlayed total (we ignore frames with 'no video', possibly B frames) and this can ultimately result in the position being behind actual by several minutes. This leads to bookmarks being set in the wrong place.

A sample of BBC HD is in the samples store.

EDIT: C4 HD issue previously described isn't reproducible so I've removed the detail of that to avoid confusion.

[mythtv@…]

This is almost certainly caused by commit 590f161. BBC HD has no IDRs. You need to use I frames for BBC HD to play back correctly.

[stuartm]

It's not unfortunately. Most obviously because that change only affects seektables generated through mythcommflag which isn't the case for recordings. Just for good measure we reverted that change and tried without. Current working theory is that it was the last ffmpeg resync.

[stuartm]

It's been traced by a user to [d34833f2], I've confirmed that reverting this commit fixes the issue.

 Temporary fix for #11159: Fix playback of HD-PVR recording
 This revert FFmpeg commit bfca35114ae174bbabd88526379d95d4022a98b1
 (ref https://ffmpeg.org/trac/ffmpeg/ticket/2062)

[stuartm]

It's also been noted that there is a stutter/flicker caused by the same commit that is probably explained by fact that every eighth frame is not being rendered.

[Martin Long <martin@…>]

Can this also be fixed in 26-fixes please? It's been making my eyes wobble since I installed this update. It seems like a massive regression.

[JYA]

Fixed in [223b6eaedd838ccf5dd55ae3c2bb20813332bf1d]