Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 15 months ago

Closed 13 months ago

Last modified 13 months ago

#11389 closed Patch - Feature (fixed)

Resync external libhdhomerun to release 20130117

Reported by: gary.buhrmaster@… Owned by: silicondust
Priority: minor Milestone: 0.27
Component: MythTV - HDHomeRun Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Resync external libhdhomerun to SiliconDust? release 20130117.

SiliconDust? has release a new stable libhdhomerun release, 20130117 (the last stable release was released in April of 2012). This patch updates the few lines from the last resync (the Novemeber beta release) to this release version. For MythTV, the changes are transparent, but using a release base should make it easier for future resyncs (due to SD release source availability practices for stable releases).

The patch is available at:

https://github.com/garybuhrmaster/mythtv/commit/558990dfe4bec1505fc89dfb1083ff29ce7e05d8

Attachments (0)

Change History (6)

comment:1 Changed 13 months ago by David Engel <dengel@…>

  • Resolution set to fixed
  • Status changed from new to closed

In c5818bd4546424a82dc9e9634597470e4169134a/mythtv:

Updated libhdhomerun to version 20130328.

Fixes #11389

comment:2 Changed 13 months ago by gigem

  • Milestone changed from unknown to 0.27

comment:3 Changed 13 months ago by Gary Buhrmaster <gary.buhrmaster@…>

Unfortunately, the commit you applied reverted the local MacOS and Windows patches. I had done a 3-way diff to make sure they were not lost in my patch(es).

comment:4 follow-up: Changed 13 months ago by gigem

Is it just the changes to hdhomerun_os_posix.h and hdhomerun_os_windows.{h,c} that need to be undone? The move of the files to external/libhdhomerun and my inability to find an original copy of the 20121107beta1 version made it hard to tell there were any local changes, so I assumed there weren't any.

comment:5 in reply to: ↑ 4 Changed 13 months ago by Gary Buhrmaster <gary.buhrmaster@…>

Replying to gigem:

Is it just the changes to hdhomerun_os_posix.h and hdhomerun_os_windows.{h,c} that need to be undone?

Fortunately, there are no differences between libhdhomerun 20130117 and 20130328, so the easiest solution would be to revert your commit, and cherry-pick my commit. But yes, those are the parts that you would need to undo (or redo) in your commit to match mine. You can do a diff on the two diff patches :-) to validate.

The move of the files to external/libhdhomerun and my inability to find an original copy of the 20121107beta1 version

That is exactly why my patch brought libhdhomerun to a current "release", as I stated in the description. It can be difficult to find/obtain older beta versions.

made it hard to tell there were any local changes, so I assumed there weren't any.

Not the first time that I (and probably others) have made that kind of mistake. That is why I have been especially pedantic regarding my patches to libhdhomerun.

comment:6 Changed 13 months ago by David Engel <dengel@…>

In cda0364ced21eb672ff2cc50700f4c3c3303c002/mythtv:

Restore local changes to libhdhomerun after previous commit.

Refs #11389

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.