Opened 11 years ago
Closed 11 years ago
Last modified 11 years ago
#11451 closed Patch - Bug Fix (fixed)
Start and end times of DVD menu highlights are ignored.
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | minor | Milestone: | 0.27 |
Component: | MythTV - DVD Playback | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Some DVD menus specify start and end times for menu highlight. Currently these times are ignored, which usually gives ugly results as the highlight is shown before the correct background is in place (e.g. text fading in) or continues to be displayed after the menu background has changed (e.g. text fading out).
The effect seems to be more noticeable when using OpenGL than VDPAU but it is visible with both.
The attached patch fixes this problem as far as currently possible.
There are currently two caveats:
- The second patch from #11371 is required to allow this patch to work across timestamp discontinuities (happens quite often when moving from an animated menu to a still menu).
- Highlights are currently hidden a little too early due to the RingBuffer? being ahead of the player. That is a separate issue that I hope to address soon.
See also the two sample images DelayedMenu_VMG.iso and DelayedMenu_VTS.iso in stuartm's DVD repository (DelayedMenu_VTS.iso has other issues fixed in #11445).
Attachments (2)
Change History (4)
Changed 11 years ago by
Attachment: | 0001-Respect-the-start-and-end-times-of-menu-highlights-t.patch added |
---|
Changed 11 years ago by
Attachment: | 0001a-Respect-the-start-and-end-times-of-menu-highlights-t.patch added |
---|
comment:1 Changed 11 years ago by
Owner: | set to Richard <peper03@…> |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:2 Changed 11 years ago by
Milestone: | unknown → 0.27 |
---|
Updated patch to apply cleanly after the 2nd patch from #11371