Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#11451 closed Patch - Bug Fix (fixed)

Start and end times of DVD menu highlights are ignored.

Reported by: peper03@… Owned by: Richard <peper03@…>
Priority: minor Milestone: 0.27
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no


Some DVD menus specify start and end times for menu highlight. Currently these times are ignored, which usually gives ugly results as the highlight is shown before the correct background is in place (e.g. text fading in) or continues to be displayed after the menu background has changed (e.g. text fading out).

The effect seems to be more noticeable when using OpenGL than VDPAU but it is visible with both.

The attached patch fixes this problem as far as currently possible.

There are currently two caveats:

  • The second patch from #11371 is required to allow this patch to work across timestamp discontinuities (happens quite often when moving from an animated menu to a still menu).
  • Highlights are currently hidden a little too early due to the RingBuffer? being ahead of the player. That is a separate issue that I hope to address soon.

See also the two sample images DelayedMenu_VMG.iso and DelayedMenu_VTS.iso in stuartm's DVD repository (DelayedMenu_VTS.iso has other issues fixed in #11445).

Attachments (2)

0001-Respect-the-start-and-end-times-of-menu-highlights-t.patch (7.2 KB) - added by peper03@… 8 years ago.
0001a-Respect-the-start-and-end-times-of-menu-highlights-t.patch (7.2 KB) - added by peper03@… 8 years ago.
Updated patch to apply cleanly after the 2nd patch from #11371

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by peper03@…

Changed 8 years ago by peper03@…

Updated patch to apply cleanly after the 2nd patch from #11371

comment:1 Changed 8 years ago by Richard <peper03@…>

Owner: set to Richard <peper03@…>
Resolution: fixed
Status: newclosed

In 3d589bc76181bb7552883e5333d2dac66d4402f8/mythtv:

Respect the start and end times of menu highlights to avoid showing the menu highlight too soon/for too long.

Fixes #11451

comment:2 Changed 8 years ago by peper03

Milestone: unknown0.27
Note: See TracTickets for help on using tickets.