Opened 12 years ago
Closed 12 years ago
Last modified 12 years ago
#11579 closed Patch - Bug Fix (fixed)
Slideshow DVDs do not play back correctly
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | minor | Milestone: | 0.27 |
| Component: | MythTV - DVD Playback | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Slideshow DVDs (i.e. when a single video frame should be displayed for an arbitrary length of time) do not play back correctly (the audio track skips very quickly). This makes playback of audio DVDs impossible.
Playback of slideshows in menus works but CPU usage rises to 100% due to the fact that the video buffers are usually used to regulate the processing of new audio/video packets. As there are always video buffers available, the audio buffers are filled with several seconds worth of data (depending on configuration this can be up to around 15 seconds) and the decoding loop spins rather than sleeps until space becomes available.
The attached patches fix this problem by generating dummy video frames as needed. They also introduce a 'DVD context' class to provide a snapshot of DVD playback, which can be passed through the chain from the ringbuffer to the decoder to (in the future) the player code. This allows the different stages to make decisions based on the state of the DVD data at the time any given frame was originally read. The ringbuffer is sometimes around 2 seconds ahead of the player, so if the player queries the current state of a value (e.g. playback time) from the ringbuffer, it may get a value that corresponds to the frame it will display in 2 seconds, not the frame it is currently displaying.
The context class will be extended in future patches.
Attachments (4)
Change History (9)
Changed 12 years ago by
| Attachment: | 0001-Add-passing-of-DVD-NAV-blocks-to-ffmpeg.patch added |
|---|
Changed 12 years ago by
| Attachment: | 0002-Add-DVD-context-class-to-encapsulate-the-state-of-th.patch added |
|---|
Changed 12 years ago by
| Attachment: | 0003-Added-more-consistent-handling-of-slide-shows-i.e.-i.patch added |
|---|
Changed 12 years ago by
| Attachment: | 0004-Handle-seeking-within-slideshows.patch added |
|---|
comment:1 Changed 12 years ago by
Sample DVD images added to stuartm's repository - StillFeatureWithAudio?.iso and Rach_Sonata2.iso
comment:4 Changed 12 years ago by
| Owner: | set to Richard <peper03@…> |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:5 Changed 12 years ago by
| Milestone: | unknown → 0.27 |
|---|
Corresponds to https://github.com/FFmpeg/FFmpeg/commit/9cde9f7