Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#11582 closed Patch - Bug Fix (fixed)

Patch for errant parenthesis in mmulticastsocketdevice.cpp - fixes coverity 746821

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Karl Egly
Priority: minor Milestone: 0.27
Component: MythTV - UPnP Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis (coverity) detected a comparison that can never be true in mmulticastsocketdevice.cpp. In fact, there was a logic error due to an errant parenthesis (one of the right parens should have been to the left of the 0 being used to check the return from setsockopt rather than comparing with the sizeof, which resulted in passing an option length of zero). This patch moves the right paren to where it should have been (probable typo in the past).

Fixes coverity 746821

Patch: ​https://github.com/garybuhrmaster/mythtv/commit/e7969e3996161ac58ab88efa87806ba9d539c21c

Change History (2)

comment:1 Changed 12 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: → fixed
Status: new → closed

In 47e3a598d7b7df59d868f0a766dd5f3e9bdc616f/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:2 Changed 12 years ago by Karl Egly

Milestone: unknown → 0.27
Owner: changed from dblain to Karl Egly
Note: See TracTickets for help on using tickets.