Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#11582 closed Patch - Bug Fix (fixed)

Patch for errant parenthesis in mmulticastsocketdevice.cpp - fixes coverity 746821

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: dekarl
Priority: minor Milestone: 0.27
Component: MythTV - UPnP Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis (coverity) detected a comparison that can never be true in mmulticastsocketdevice.cpp. In fact, there was a logic error due to an errant parenthesis (one of the right parens should have been to the left of the 0 being used to check the return from setsockopt rather than comparing with the sizeof, which resulted in passing an option length of zero). This patch moves the right paren to where it should have been (probable typo in the past).

Fixes coverity 746821

Patch: https://github.com/garybuhrmaster/mythtv/commit/e7969e3996161ac58ab88efa87806ba9d539c21c

Attachments (0)

Change History (2)

comment:1 Changed 11 months ago by Gary Buhrmaster <gary.buhrmaster@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 47e3a598d7b7df59d868f0a766dd5f3e9bdc616f/mythtv:

Fix for (likely) typo in checking setsockopt return code

There was a logic error due to an errant parenthesis
that was (likely) intended to be used to check the
return code from setsockopt, but instead resulted in
a value of zero being used for the length of the
operand. This patch moves the right paren to where
it should have been.

Fixes coverity 746821
Fixes #11582

comment:2 Changed 11 months ago by dekarl

  • Milestone changed from unknown to 0.27
  • Owner changed from dblain to dekarl

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.