Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11704 closed Bug Report - General (fixed)

MythArchive animated menus: thumblist does not define thumbnail videos.

Reported by: J.Pilk@… Owned by: Paul Harrison <pharrison@…>
Priority: minor Milestone: 0.27
Component: Plugin - MythArchive Version: 0.26-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

As a one-off I wanted custom chapter points. Usually I never look at them. The non-animated ones look fine, and chapter selection works.

mythburn.py, line 3186, --thumblist < starttime, which looks (to me) like a constant here - although the thumbnail videos don't all look the same. My log has an exit-status error here, too.

Attachments (1)

animatedmenu.patch (2.6 KB) - added by J.Pilk@… 6 years ago.
unified diff from my modified version of mythburn.py for 0.26-fixes.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by J.Pilk@…

Extract from progress.log. code 34 is probably spurious (#11547) and I suppose 661 might be a node identifier. Only one instance of this message in the log, triggered by the status failure.

Using user defined thumb images - 00:00:45,00:11:46,00:22:47,00:33:50,00:44:53,00:55:54,01:06:52,01:17:54

13:13:49 mytharchivehelper failed with code 34. Command = mytharchivehelper -q -q --createthumbnail --infile "/home/John/arctmp/work/1/stream.mv2" --thumblist '661' --outfile "/home/John/arctmp/work/1/preview/preview-i1-t%1-f%2.jpg" --framecount 250

13:14:34 Added image /usr/share/mythtv/mytharchive/themes/MythCenter_-_Animated/preview-frame.png

There were four recordings, eight chapters each.

comment:2 Changed 6 years ago by J.Pilk@…

log with mythburn.py patched to show commands generated:

22:51:44 Using user defined thumb images - 00:00:44,00:11:46,00:22:47,00:33:52,00:44:52,00:55:54,01:06:52,01:17:54 22:51:44 mytharchivehelper -q -q --createthumbnail --infile "/home/John/arctmp/work/1/stream.mv2" --thumblist '0' --outfile "/home/John/arctmp/work/1/preview/preview-i0-t%1-f%2.jpg" --framecount 250 22:51:48 mytharchivehelper -q -q --createthumbnail --infile "/home/John/arctmp/work/1/stream.mv2" --thumblist '661' --outfile "/home/John/arctmp/work/1/preview/preview-i1-t%1-f%2.jpg" --framecount 250 22:51:53 mytharchivehelper -q -q --createthumbnail --infile "/home/John/arctmp/work/1/stream.mv2" --thumblist '1322' --outfile "/home/John/arctmp/work/1/preview/preview-i2-t%1-f%2.jpg" --framecount 250 22:51:59 mytharchivehelper -q -q --createthumbnail --infile "/home/John/arctmp/work/1/stream.mv2" --thumblist '1983' --outfile "/home/John/arctmp/work/1/preview/preview-i3-t%1-f%2.jpg" --framecount 250

... and so on. Thumblist sequence is 0, 661, 1322, 1983, 2644, 3305, 3966, 4627; this seems to be the autogenerated one.

comment:3 Changed 6 years ago by J.Pilk@…

mythburn.py, line 3737, previewtime+=previewsegment

How can it be changed to being defined by the thumblist?

Changed 6 years ago by J.Pilk@…

Attachment: animatedmenu.patch added

unified diff from my modified version of mythburn.py for 0.26-fixes.

comment:4 Changed 6 years ago by J.Pilk@…

This patch has worked for me. User-generated markers have the format u'01:06:52', auto-generated markers don't have the 'u'. I don't know if this is intentional. Both seem acceptable.

comment:5 Changed 6 years ago by J.Pilk@…

I think this patch, which does work, ought to be accompanied by a sanity check; thumb markers increasing, first > 0, last at least 10 s before EOF. If not true dvdauthor will probably fail. The check could and should be done much earlier, and the thumblists ought to be non-volatile in case of job failure. FRWOP, I'm afraid. Just a warning.

comment:6 Changed 6 years ago by paulh

Component: MythTV - GeneralPlugin - MythArchive

comment:7 Changed 6 years ago by Paul Harrison <pharrison@…>

Owner: set to Paul Harrison <pharrison@…>
Resolution: fixed
Status: newclosed

In 3984147e51f628b2d6c76a941191fb5501ed057a/mythtv:

mythburn.py: fix animated chapter menu when using user defined chapters

The animated chapter menu was never updated to take into account user defined
chapter points so was always using the fixed chapter points.

Fixes #11704.

comment:8 Changed 6 years ago by Paul Harrison <pharrison@…>

In addb240d3c7968a2856c54ef76aa50fda6799b9c/mythtv:

mythburn.py: fix animated chapter menu when using user defined chapters

The animated chapter menu was never updated to take into account user defined
chapter points so was always using the fixed chapter points.

Fixes #11704.

(cherry picked from commit 3984147e51f628b2d6c76a941191fb5501ed057a)

comment:9 Changed 6 years ago by paulh

Milestone: unknown0.27
Note: See TracTickets for help on using tickets.