Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#11947 closed Patch - Feature (fixed)

[PATCH] Read embedded images from FLAC files

Reported by: Karl Newman <SiliconFiend@…> Owned by: Karl Newman <SiliconFiend@…>
Priority: minor Milestone: 0.28
Component: Plugin - MythMusic Version: 0.27-fixes
Severity: medium Keywords: flac, album art, images, embedded
Cc: Ticket locked: no

Description

I wrote up a patch which uses taglib to read and write embedded images in FLAC music files (patterned after the support for ID3-tagged files). For some reason it only seems to work if you go to Edit Metadata->Album Art->(Menu)->Rescan for images. It doesn't get picked up when you modify the file and perform a scan for new music. Perhaps there is some method in the scanner which is not hitting the right code paths?

Attachments (1)

flac_embedded_art.patch​ (12.2 KB) - added by Karl Newman <SiliconFiend@…> 8 years ago.
Add embedded art support for FLAC files

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Karl Newman <SiliconFiend@…>

Attachment: flac_embedded_art.patch​ added

Add embedded art support for FLAC files

comment:1 Changed 8 years ago by Karl Newman <SiliconFiend@…>

In 5acb781cf80c316ad7b947da677506c0f893cb4e/mythtv:

MythMusic: add support for embedded images in flac xiphComment tags

Refs #11947.

Signed-off-by: Paul Harrison <pharrison@…>

comment:2 Changed 8 years ago by Karl Newman <SiliconFiend@…>

Owner: set to Karl Newman <SiliconFiend@…>
Resolution: → fixed
Status: new → closed

In 0e8e2e3527ad26d34edb5899300cef0d9e863bce/mythtv:

MythMusic: prefer xiphComment style tags in flac files

Closes #11947.

Signed-off-by: Paul Harrison <pharrison@…>

comment:3 Changed 8 years ago by Paul Harrison <pharrison@…>

In e02bbc5ebda1ab8cf8616829a03f96a4e4918e03/mythtv:

MythMusic: fix compilation for users of taglib < 1.8

Seems you need tablib >= 1.8 to remove Picture blocks from xiph comments
but the minimum we currently support is 1.6 so since this is a rarely used
feature just disable it on taglib < 1.8 for now.

Refs #11947.

comment:4 Changed 8 years ago by Raymond Wagner

Milestone: unknown → 0.28
Note: See TracTickets for help on using tickets.