Opened 6 years ago

Closed 4 years ago

#12061 closed Patch - Bug Fix (Fixed)

Music Mini Player restarts playback on an old saved position

Reported by: angela.schmid@… Owned by:
Priority: minor Milestone: 0.28
Component: Plugin - MythMusic Version: 0.27-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

MusicPlayer? saves positions only on a complete stop in the music dialogs or upon destroy. When in the music dialog exit is pressed with further play option, the MusicPlayer? does not save its position. When the MiniPlayer? dialog is opened, the player stopped and the MiniPlayer? dialog is closed, then when the MiniPlayer? dialog is opened again MusicCommon::CreateCommon? is called and !gPlayer->isPlaying() is true, an old saved position is restored.

!gPlayer->isPlaying() is normally used to start playback on entry of the music dialogs.

With the “further play option” there exists a MusicPlayer? instance and holds during all times a valid position, therefor when opening the MiniPlayer? dialog (see MusicCommon::CreateCommon?) does not have to reposition.

Attachments (1)

0001-Music-Mini-Player-does-not-need-to-reposition-on-re-.patch (1.9 KB) - added by angela.schmid@… 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by angela.schmid@…

comment:1 Changed 4 years ago by angela.schmid@…

Changes in 0.28 fixed this issue.

comment:2 Changed 4 years ago by Stuart Auchterlonie

Milestone: unknown0.28
Resolution: Fixed
Status: newclosed

Thanks for letting us know this was fixed.

Note: See TracTickets for help on using tickets.