Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#12062 closed Bug Report - General (fixed)

MythMusic returning from TV/video playback fails to seek correct

Reported by: angela.schmid@… Owned by: angelaschmid <angela.schmid@…>
Priority: minor Milestone: 0.27.1
Component: Plugin - MythMusic Version: 0.27-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When “continue play music” is active and after TV/video playback, the music track is not seeked correct.

When TV/video playback is finished MusicPlayer::StartPlayback? is called, who calls play(). Play() stops and starts the decoder. The decoder (thread) opens the music file again. The call to seek() is called, but the decoder thread is not yet ready. The seek position is cleared in the DB.

The decoder gets active and the MusicPlayer::decoderHandlerReady Event is called, it tries also to seek but reads cleared positions from the DB.

2014-02-16 17:15:43.070828 E [26990/26990] CoreContext? musicplayer.cpp:517 (StartPlayback?) - MusicPlayer?: StartPlayback? 2014-02-16 17:15:43.071231 E [26990/26990] CoreContext? musicplayer.cpp:522 (StartPlayback?) - MusicPlayer::StartPlayback?: MusicBookmarkPosition:236 2014-02-16 17:15:43.071242 I [26990/26990] CoreContext? decoderhandler.cpp:399 (stop) - DecoderHandler?: Stopping decoder 2014-02-16 17:15:43.287610 I [26990/26990] CoreContext? decoderhandler.cpp:328 (doStart) - Track 0 = /store/store13/music/aaa.mp3 2014-02-16 17:15:43.287626 I [26990/26990] CoreContext? decoderhandler.cpp:382 (next) - Now playing 'file:///store/store13/music/aaa.mp3' 2014-02-16 17:15:43.287648 I [26990/26990] CoreContext? decoderhandler.cpp:133 (start) - DecoderIOFactory: Opening Local File /store/store13/music/aaa.mp3 2014-02-16 17:15:43.287706 E [26990/26990] CoreContext? musicplayer.cpp:1034 (seek) - MusicPlayer::seek, isRunning: 0 2014-02-16 17:15:48.287820 E [26990/26990] CoreContext? musicplayer.cpp:1045 (seek) - MusicPlayer::seek:236 2014-02-16 17:15:48.389138 I [26990/26990] CoreContext? musicplayer.cpp:1446 (decoderHandlerReady) - decoder handler is ready, decoding file:///store/store13/music/aaa.mp3 2014-02-16 17:15:48.389190 I [26990/26990] CoreContext? avfdecoder.cpp:249 (initialize) - avfDecoder: playing file /store/store13/music/aaa.mp3

The fix does not call seek and clear the seek position in the DB in MusicPlayer::StartPlayback?(), allowing MusicPlayer::decoderHandlerReady to find correct seek values in the DB.

Log after the fix: 2014-02-16 17:26:03.747722 E [27945/27945] CoreContext? musicplayer.cpp:517 (StartPlayback?) - MusicPlayer?: StartPlayback? 2014-02-16 17:26:03.748110 E [27945/27945] CoreContext? musicplayer.cpp:522 (StartPlayback?) - MusicPlayer::StartPlayback?: MusicBookmarkPosition:564 2014-02-16 17:26:03.748118 I [27945/27945] CoreContext? decoderhandler.cpp:399 (stop) - DecoderHandler?: Stopping decoder 2014-02-16 17:26:03.888778 I [27945/27945] CoreContext? decoderhandler.cpp:328 (doStart) - Track 0 = /store/store13/music/aaa.mp3 2014-02-16 17:26:03.888796 I [27945/27945] CoreContext? decoderhandler.cpp:382 (next) - Now playing 'file:///store/store13/music/aaa.mp3' 2014-02-16 17:26:03.888819 I [27945/27945] CoreContext? decoderhandler.cpp:133 (start) - DecoderIOFactory: Opening Local File /store/store13/music/aaa.mp3 2014-02-16 17:26:03.896456 I [27945/27945] CoreContext? musicplayer.cpp:1443 (decoderHandlerReady) - decoder handler is ready, decoding file:///store/store13/music/aaa.mp3 2014-02-16 17:26:03.896489 I [27945/27945] CoreContext? avfdecoder.cpp:249 (initialize) - avfDecoder: playing file /store/store13/music/aaa.mp3 2014-02-16 17:26:03.901288 E [27945/27945] CoreContext? musicplayer.cpp:1035 (seek) - MusicPlayer::seek, isRunning1: 1 2014-02-16 17:26:03.901294 E [27945/27945] CoreContext? musicplayer.cpp:1042 (seek) - MusicPlayer::seek:564 2014-02-16 17:26:03.901345 I [27945/28061] avfDecoder avfdecoder.cpp:447 (run) - avfdecoder.o: seek time 564

Attachments (1)

0001-MythMusic-fixes-seek-problem-with-restart-playback.patch (1.8 KB) - added by angela.schmid@… 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by angela.schmid@…

comment:1 Changed 6 years ago by angelaschmid <angela.schmid@…>

Owner: set to angelaschmid <angela.schmid@…>
Resolution: fixed
Status: newclosed

In 8af587a2c49d5411db0b46530f111e9aba85d72f/mythtv:

MythMusic: fix seek problem with restart playback.

When resuming after TV/video playback, the music track was resuming at the
start rather than seeking to the correct position.

#Fixes #12062.

Signed-off-by: Paul Harrison <pharrison@…>

comment:2 Changed 6 years ago by angelaschmid <angela.schmid@…>

In aea35739f890294f537ed609e195ec233334c904/mythtv:

MythMusic: fix seek problem with restart playback.

When resuming after TV/video playback, the music track was resuming at the
start rather than seeking to the correct position.

#Fixes #12062.

Signed-off-by: Paul Harrison <pharrison@…>
(cherry picked from commit 8af587a2c49d5411db0b46530f111e9aba85d72f)

comment:3 Changed 6 years ago by paulh

Milestone: unknown0.27.1
Note: See TracTickets for help on using tickets.