Opened 6 years ago

Closed 5 years ago

#12087 closed Bug Report - General (fixed)

Duplicate recordings due to ' Also in HD.' description

Reported by: grandmastermarclar@… Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.27.4
Component: MythTV - General Version: 0.27-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

BBC standard definition channels will often have programme descriptions identical to their high definition counterparts, but with the suffix ' Also in HD.'.

This can cause some recording schedules to pick up multiples of the same programme, needlessly occupying multiple tuners which can have knock on effects for other recording schedules.

In the same way as per 11715, could this suffix please be removed?

Attachments (2)

alsoinhd.patch (1.0 KB) - added by Alan Nimmo <alanjnimmo@…> 5 years ago.
Patch to remove 'Also in HD' from BBC programme descriptions
alsoinhd2.patch (1.4 KB) - added by Alan Nimmo <alanjnimmo@…> 5 years ago.
Fixed version of the previous patch

Download all attachments as: .zip

Change History (12)

Changed 5 years ago by Alan Nimmo <alanjnimmo@…>

Attachment: alsoinhd.patch added

Patch to remove 'Also in HD' from BBC programme descriptions

comment:1 Changed 5 years ago by Alan Nimmo <alanjnimmo@…>

I too have been having trouble with these duplicate programmes, so I've come up with the attached patch which removes the 'Also in HD' text from the SD descriptions.

comment:2 Changed 5 years ago by Karl Egly

Does that patch work? It looks like it is just defining the regular expression but not performing the actual removal, see https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythtv/eitfixup.cpp#L720 It also appears to be missing the white space cleanup. e.g. \\s? or similar

comment:3 Changed 5 years ago by stuartm

Milestone: unknown0.27.4
Owner: set to Stuart Auchterlonie
Status: newassigned

There must be something else going wrong here, BBC programmes should have unique programids and so we'd never even get as far as comparing the descriptions.

Changed 5 years ago by Alan Nimmo <alanjnimmo@…>

Attachment: alsoinhd2.patch added

Fixed version of the previous patch

comment:4 Changed 5 years ago by J.Pilk@…

My first experience of Master, v0.28-pre-2167-gfd72f58

Using EIT, select a programme on one of the HD/SD BBC Channels and _both_ are shown in the Upcoming Recordings screen, with the same tuner number. The one originally selected is recorded. On this box I only have one tuner, which is HD/SD capable, and only one Programme Source is defined. The BBC Programme ID is shared.

comment:5 Changed 5 years ago by Alan Nimmo <alanjnimmo@…>

Apologies for the incomplete previous patch. I originally built and tested against fixes/0.27, but somewhere during the process of rebuilding against the master branch, I lost the line of code that did the actual removal. Sorry about that. A corrected patch is attached.

@dekarl Yeah, I originally had \\s* at the start of the regex, but for some reason that wasn't working, and when I removed it, I found that some other code (presumably also in eitfixup) was trimming any remaining blank space from the end.

This is the first change I've submitted to MythTV, and the regex may not be as good as it could be, but it certainly worked well when I tested it on my 0.27 setup.

@stuartm When I first started investigating this, I checked whether the programmes concerned had programids, but quite a few of mine don't (it's mostly BBC Three programmes I'm having trouble with). Hence why I wanted to submit this solution which works well for me.

comment:6 Changed 5 years ago by stuartm

John: Ok, I now realise what's happening here. It's not going to record both, it just looks that way currently because we're in the middle of some changes in the way these situations are handled. A recent commit removed the 'other showing' state to simplify some of the code and the corresponding changes have yet to be made in the frontend (and webfrontend) to correctly reflect the difference between the "will record" and "will record on a different channel" status of these recordings.

comment:7 Changed 5 years ago by J.Pilk@…

Apologies; in my recent post only one instance is shown in 'Upcoming Recordings', but in the Programme Guide and in the 'Future Showings' ('O') screens both are shown as selected.

comment:8 Changed 5 years ago by stuartm

Alan: Can you check whether the defaultAuthority is populated for that channel in the database? Also check the multiplex in the dtv_multiplex table. If it's missing that would explain the lack of program ids. We should populate that field when scanning, but if for some reason it wasn't available at the time we scanned then it prevents the insertion of program ids from the EIT data.

comment:9 Changed 5 years ago by Alan Nimmo <alanjnimmo@…>

Aha, yes it looks like you're onto something here, none of my BBC Three, BBC Three HD, BBC Four and BBC Four HD channels have the default_authority set (all the other BBC channels do). Thinking back, I have seen this problem with BBC Four as well, so that also fits the pattern.

Those channels would have been off-air when I last did a channel scan (I usually do scans in the afternoon when MythTV has nothing scheduled), could that have something to do with why the default_authority field is not being set for those off-air channels, but is for the other BBC channels?

I also checked the dtv_multiplex table, but none of the rows have that field set to anything.

comment:10 Changed 5 years ago by Richard Hulme <peper03@…>

Resolution: fixed
Status: assignedclosed

In b7545af2365e90be3cd9291aa733a35f4809f900/mythtv:

Add removal of 'Also in HD' to UK EIT fixups to avoid duplicate recordings in case programme IDs etc. get lost.
Original patch from Alan Nimmo, extended to include whitespace.

Fixes #12087

Note: See TracTickets for help on using tickets.