Opened 10 years ago

Closed 10 years ago

#12233 closed Patch - Bug Fix (fixed)

Patch to check return values on seek - Fixes Coverity 746749 & 1073815

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: minor Milestone: 0.28
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In libmythtv/ringbuffer.cpp Coverity reports two seeks with uncheck return values. While the comment says the seek(s) can never fail, static analysis suggests checking is goodness (and "impossible" failures do occur). The included patch checks the return values, and logs an error if the impossible occurs.

Fixes Coverity 746749 & 1073815

github ref: ​https://github.com/garybuhrmaster/mythtv/commit/5a3992d3c0ed360edcb19fc7f5c53d8f06641804 github git-am ref: ​https://github.com/garybuhrmaster/mythtv/commit/5a3992d3c0ed360edcb19fc7f5c53d8f06641804.patch

Change History (3)

comment:1 Changed 10 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Corrected patch to resolve static analysis detected potential issue with uninitialized value.

github ref: ​https://github.com/garybuhrmaster/mythtv/commit/8eb48410d9ecd93af05323a34d019e614c364a8f github git-am ref: ​https://github.com/garybuhrmaster/mythtv/commit/8eb48410d9ecd93af05323a34d019e614c364a8f

comment:2 Changed 10 years ago by stuartm

Milestone: unknown → 0.28
Owner: set to stuartm
Status: new → accepted

comment:3 Changed 10 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: → fixed
Status: accepted → closed

In 8a37d0af58797a0f7a99bd751ecf59061c94a86a/mythtv:

Check the return values from seek requests

Fixes Coverity 746749 & 1073815
Fixes #12233

Signed-off-by: Stuart Morgan <smorgan@…>

Note: See TracTickets for help on using tickets.