Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#12260 closed Patch - Bug Fix (fixed)

Patch: Making recordedid the primary key for recorded breaks the python bindings

Reported by: doug@… Owned by: Raymond Wagner
Priority: minor Milestone: 0.28
Component: Bindings - Python Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

There are a number of scripts that depend on the Recorded class taking the chanid/starttime instead of the recordedid as the primary key. This patch updates the Recorded class to continue using the chanid/starttime pair. A future patch can add recordedid as a second option so as not to break backwards compatibility.

Attachments (2)

dataheap.patch (685 bytes) - added by doug@… 5 years ago.
0001-Fix-python-bindings-for-Recorded-Seek-Mark.patch (1.1 KB) - added by angela.schmid@… 4 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by doug@…

Attachment: dataheap.patch added

comment:1 Changed 5 years ago by Raymond Wagner

Milestone: unknown0.28
Status: newaccepted
Version: UnspecifiedMaster Head

Changed 4 years ago by angela.schmid@…

comment:2 Changed 4 years ago by angela.schmid@…

Too bad this has not been fixed for 0.28. I had problems with Lossless Cut.

The attached fix still uses the recordedid as the primary key for recorded. Instead it set the attributes to be used for recordedseek and recordedmarkup.

comment:3 Changed 4 years ago by angelaschmid <angela.schmid@…>

Resolution: fixed
Status: acceptedclosed

In fed010634249265550383d45e1d95ebde8194639/mythtv:

Fixes #12260. Fix python bindings after the change to recordedid being the primary key

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:4 Changed 3 years ago by Roger Siddons <rsiddons@…>

In ce1935b0ebc0918391f05893be82cd275cbd3969/mythtv:

Python: Restore chanId/startTime API for recordings

Exisiting python scripts depend on the Recorded class taking the chanid/starttime instead of the recordedid as the primary key.
This patch updates the Recorded class to continue using the chanid/starttime pair.
A future patch can add recordedid as a second option so as not to break backwards compatibility.

Fixes: #12260

comment:5 Changed 3 years ago by Roger Siddons <rsiddons@…>

In 2ead1a6c9ebc7c39d868c6baeb5f209cd937c087/mythtv:

Python: Restore chanId/startTime API for recordings

Exisiting python scripts depend on the Recorded class taking the chanid/starttime instead of the recordedid as the primary key.
This patch updates the Recorded class to continue using the chanid/starttime pair.
A future patch can add recordedid as a second option so as not to break backwards compatibility.

Fixes: #12260
(cherry picked from commit ce1935b0ebc0918391f05893be82cd275cbd3969)

comment:6 Changed 3 years ago by john.sweeney@…

I am still getting an error related to this problem:

File "/usr/lib/python2.7/dist-packages/MythTV/dataheap.py", line 332, in init

DBDataWrite.init(self, data, db)

@------------- @ data = [1034, datetime(2016, 7, 28, 11, 30, tzinfo=<MythTV.utility.dt.offsettzinfo object at 0x7fdea8fecc90>)] @ self = <Unknown due to: 'NoneType?' object has no attribute 'isoformat'> @ db = <MythDB 'sql://mythconverg@bondo:3306/' at 0x7fdea8b60610>

I am using silence.py, and after an OS upgrade this problem has appeared.

comment:7 Changed 3 years ago by mark@…

Sorry folks but has this problem been fixed,.. and if so what is the recommended solution as the wiki claims silence.py works with 0.28.... I have read stuff about appending "/" to folder names,..already present and updating a python bindings library,. and mine is already up to date... So I am a little stumped as to how to fix silence. many tx

comment:8 in reply to:  7 Changed 3 years ago by mark@…

Replying to mark@…:

Sorry folks but has this problem been fixed,.. and if so what is the recommended solution as the wiki claims silence.py works with 0.28.... I have read stuff about appending "/" to folder names,..already present and updating a python bindings library,. and mine is already up to date... So I am a little stumped as to how to fix silence. many tx

update,.. Yes issue is fixed,.. add PPA fixes 0.28 and update/upgrade... ( I had Kernel issues which messed all updates including my fixes0.28,.. and confused me )

Note: See TracTickets for help on using tickets.