Opened 13 years ago

Closed 13 years ago

#1232 closed patch (fixed)

"Recorded Programs" needs to load all channel data.

Reported by: Robert Tsai <rtsai1111> Owned by: xris
Priority: minor Milestone: 0.19
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The "Recorded Programs" page uses QUERY_RECORDINGS from the mythbackend; that picks up chanids used to make the recordings. The routine load_all_channels performs a "GROUP BY channel.channum"; this can end up hiding chanids that are referenced by the backend results, which results in the "Recorded Programs" page sometimes being unable to fill in the "channum" column.

This patch:

  • Removes the GROUP BY from load_all_channels. Rather than re-key the $Channels array by channum, we simply make sure that all chanids are represented in the $Channels array (which means there could be object copies if two chanids refer to the same channum/callsign).
  • Adds a call to load_all_channels in modules/tv/recorded.php, like many of the other modules.

There are a few other places that might need calls to load_one_channel (" No channel data? Load it"), but I don't address those.

Attachments (3)

mythweb.recorded.diff (2.3 KB) - added by Robert Tsai <rtsai1111> 13 years ago.
mythweb.recorded.2.diff (3.7 KB) - added by Robert Tsai <rtsai1111> 13 years ago.
WAP and WML themes not tested
mythweb.recorded.3.diff (9.8 KB) - added by Robert Tsai <rtsai1111> 13 years ago.
More group-by-channum fixes. Re-expose "nodups" UI for searches. Fix some calls to load_all_channels.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by Robert Tsai <rtsai1111>

Owner: changed from Isaac Richards to xris

Changed 13 years ago by Robert Tsai <rtsai1111>

Attachment: mythweb.recorded.diff added

comment:2 Changed 13 years ago by Robert Tsai <rtsai1111>

This patch is wrong; it re-doubles all the channels in the TV listings.

comment:3 Changed 13 years ago by Robert Tsai <rtsai1111>

This new patch loads all channels from the channel data (no more GROUP BY). The old GROUP BY effect is now explicitly implemented in the channel listings by keeping track of which channum's have already been displayed and not displaying any repeats.

Changed 13 years ago by Robert Tsai <rtsai1111>

Attachment: mythweb.recorded.2.diff added

WAP and WML themes not tested

comment:4 Changed 13 years ago by xris

this works, but after applying it, I'm also seeing everything without a program/seriesid show up as already-recorded. Did you have a fix for that one? Would be nice to get it in before .19 comes out.

comment:5 Changed 13 years ago by xris

Milestone: 0.19

comment:6 Changed 13 years ago by Robert Tsai <rtsai1111>

Right. The already-recorded stuff will be addressed in #1054.

Changed 13 years ago by Robert Tsai <rtsai1111>

Attachment: mythweb.recorded.3.diff added

More group-by-channum fixes. Re-expose "nodups" UI for searches. Fix some calls to load_all_channels.

comment:7 Changed 13 years ago by xris

Resolution: fixed
Status: newclosed

(In [8914]) Apply patches, and some of my own cleanup to close #1232 and #1054

Note: See TracTickets for help on using tickets.