Opened 5 years ago

Closed 5 years ago

#12484 closed Patch - Bug Fix (Invalid)

Workaround for Qt5 <shape> drawing behavior change

Reported by: Jim Stichnoth Owned by: stuartm
Priority: minor Milestone: 0.28
Component: MythTV - User Interface Library Version: Master Head
Severity: medium Keywords: qt5
Cc: Ticket locked: no

Description

With Qt5, a <shape> element that lacks an explicit <line> element is drawn differently than with Qt4 - a 1-pixel invisible border is "stolen" from the shape's exterior. This can be very noticeable with small shapes, such as cutlist editor cursor marks, or precisely aligned shapes, such as a background drawn behind subtitles.

This patch changes the default <shape> behavior when no <line> is specified - the line is set to the shape's fill color with a width of 0.

[stuartm: please have a look at this, thanks!]

Attachments (1)

mythuishape_qt5_v1.patch (2.3 KB) - added by Jim Stichnoth 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by Jim Stichnoth

Attachment: mythuishape_qt5_v1.patch added

comment:1 Changed 5 years ago by stuartm

Status: newaccepted

comment:2 Changed 5 years ago by Stuart Auchterlonie

Keywords: qt5 added

comment:3 Changed 5 years ago by J.Pilk@…

With today's build of master from the *buntu ppa the SD edit marker is visible again without a post-installation patch. I think commit 521b12bb52ddc7282745d7dbbdd8ea2433c95dcb probably fixed it.

I had a hard time finding the original reference, but I think http://www.gossamer-threads.com/lists/mythtv/users/588659#588659 was the first I saw of it.

comment:4 Changed 5 years ago by Jim Stichnoth

Resolution: Invalid
Status: acceptedclosed

Thanks! I also see that the behavior now seems fixed without my patch.

Note: See TracTickets for help on using tickets.