IPTV/Freebox multiple recorders issue (both transition as new setup)

[charles.bovy@…]

There are two scenarios:

1. upgrade from 0.27.5 with two separate IPTV/Freebox recorders, pointing to same URL m3u file, same host, same videosource
2. create two separate new IPTV/Freebox recorders in master, pointing to same URL m3u file, same host, same videosource

Scenario 1: The two separate IPTV/Freebox recorders get consolidated into one recorder, with multirec. In master, table inputgroup is used for Freebox recorder. For the two recorders, there is one inputgroupid, so no two simultaneous recordings possible on different channels. Changing one of them manually to a unique inputgroupid, everything works as in 0.27.5

My conclusion: during transition, the two unrelated Freebox recorders are merged into one recorder with multirec enabled. Possibly possible due to same URL to m3u file, so inputgroupname is the same.

Transition needs to be checked and fixed.

Scenario 2: I've added two IPTV/Freebox recorders, with same URL to M3U file. I connect them both to the same videosource. The two recorders end up with the same inputgroupid, where they should have different inputgroupids. The inputgroupname is the same due to the host and M3U url (example: inputgroupname = hostnamehttp://192.168.1.1/file.m3u). Changing one of them manually to a unique inputgroupid, everything works as in 0.27.5

My conclusion: Creating two separate recorders works, but they get the same inputgroupid because of the inputgroupname is the same.

The creation of IPTV recorders and assigning unique inputgroupids needs to be reviewed.

[charles.bovy@…]

unique inputgroupids are based on unique inputgroupname.

The inputgroupname consists of 'hostname|m3u-url' for both recorders:

"ubuntu|http://192.168.1.1/file.m3u"

So because inputgroupname is exactly the same, there is no unique inputgroupid created, but existing inputgroupid used (see CardUtil::CreateInputGroup?() in cardutil.cpp).

In the Freebox-world, the same m3u URL can be used for multiple recorders so we need to differentiate. What are the possibilities to add a count while creating the inputgroup? Maybe work with the parentid to determine uniqueness? Example:

"ubuntu|http://192.168.1.1/file.m3u|1"
"ubuntu|http://192.168.1.1/file.m3u|2"

[David Engel <dengel@…>]

In f12a78e606af2a8995947b65d496e91e954d4ee8/mythtv:

Fix inputgroups for non-device recorders.

It's possible from non-device recorders, like FREEBOX/IPTV and DEMO to
use the same 'device'. They should not be in the same inputgroup.
Any child/multirec inputs should be in the same group, however. Fix
this including the parent cardid in the inputgroup name.

Fixes #12598

[David Engel <dengel@…>]

In f12a78e606af2a8995947b65d496e91e954d4ee8/mythtv:

Fix inputgroups for non-device recorders.

It's possible from non-device recorders, like FREEBOX/IPTV and DEMO to
use the same 'device'. They should not be in the same inputgroup.
Any child/multirec inputs should be in the same group, however. Fix
this including the parent cardid in the inputgroup name.

Fixes #12598