Opened 9 years ago

Closed 9 years ago

#12599 closed Patch - Bug Fix (fixed)

AllowTagWriting setting default mismatch

Reported by: Mike Rice <mikerice1969@…> Owned by: paulh
Priority: minor Milestone: 0.28
Component: Plugin - MythMusic Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Noticed this on my testbox with a brand new database.

The settings screen uses a default of 1 for AllowTagWriting?:

int allowTagWriting = gCoreContext->GetNumSetting?("AllowTagWriting?", 1);

Therefore when it doesn't exist in the database yet the checkbox is checked, the user thinks he/she will be writing to tags, and won't think a save is needed.

The uses of the setting in editmetadata.cpp and musicplayer.cpp use 0 as the default:

if (GetMythDB()->GetNumSetting?("AllowTagWriting?", 0))

So until that settings screen is saved the AllowTagWriting? functionality will not be enabled even though it looks like it on the settings screen.

Attachments (1)

settings_AllowTagWriting.patch​ (665 bytes) - added by Mike Rice <mikerice1969@…> 9 years ago.
patch

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by Mike Rice <mikerice1969@…>

Attachment: settings_AllowTagWriting.patch​ added

patch

comment:1 Changed 9 years ago by Stuart Auchterlonie

Milestone: unknown → 0.28

comment:2 Changed 9 years ago by Mike Rice <mikerice1969@…>

Resolution: → fixed
Status: new → closed

In f30488b8a99de46bdc7815c40b6a90a7c237fd64/mythtv:

MythMusic: fix AllowTagWriting? setting default mismatch

Closes #12599

Signed-off-by: Paul Harrison <pharrison@…>

Note: See TracTickets for help on using tickets.