Opened 3 years ago

Closed 3 years ago

Last modified 18 months ago

#12892 closed Bug Report - General (fixed)

Gallery View jumps around when navigating bottom ~ 2 rows of videos

Reported by: kc8vfa@… Owned by: Peter Bennett
Priority: minor Milestone: unknown
Component: MythTV - User Interface Library Version: Unspecified
Severity: medium Keywords: Gallery View, navigation
Cc: Ticket locked: no

Description

I have a video showing the issue. https://youtu.be/dn5u74tDt8I

brfransen has a better grasp on the issue...

"This seems to only affect Gallery View. What looks like is happening is that when it has to scroll and the last row is not a full row (16 items in the case of the LH theme) it refreshes the last two rows to show them as full rows but the navigation thinks it should only be a partial row. "

Change History (7)

comment:1 Changed 3 years ago by paulh

Component: MythTV - Video LibraryMythTV - User Interface Library
Owner: changed from JYA to jpoet
Status: newassigned

This sounds like the bug I reported to John 3 or 4 weeks ago. I guess it must not affect him otherwise it's such an annoying bug he would have fixed it by now :)

For now reverting these commits returns things to normal https://github.com/MythTV/mythtv/commit/3342f6a306 https://github.com/MythTV/mythtv/commit/38ca7f701d

comment:2 Changed 3 years ago by jpoet

Indeed, it does not affect the Steppes theme ;-)

Steppes uses the 'stack' arrangement mode. Mythcenter-wide uses the 'fixed' arrangement mode. So, I am assuming the issue only impacts the fixed mode.

I will try to look at it this weekend.

comment:3 Changed 3 years ago by Peter Bennett

Owner: changed from jpoet to Peter Bennett

John Poet said:

In my opinion, reverting those commits does not make any sense. Those commits fix a much more common problem which affects the main 'Watch Recordings' screen. This issue only affects users using a grid-view, which they have the option of not using.

If this issue is more important to you, the following will "fix" it at the expense of https://code.mythtv.org/trac/ticket/8441 :

diff --git a/mythtv/libs/libmythui/mythuibuttonlist.cpp b/mythtv/libs/libmythui/
index 9c25ff4..988b1b6 100644
--- a/mythtv/libs/libmythui/mythuibuttonlist.cpp
+++ b/mythtv/libs/libmythui/mythuibuttonlist.cpp
@@ -1335,13 +1335,15 @@ void MythUIButtonList::CalculateButtonPositions(void)
                                     m_columns * m_columns;
             }
 
-
+#if 0
+            // Adjusted if last item is deleted
             if (((m_itemList.count() - m_topPosition)
                  < static_cast<int>(m_itemsVisible)) &&
                 (m_selPosition - (static_cast<int>(m_itemsVisible) - 1)
                  < m_topPosition))
                 m_topPosition = m_selPosition -
                                 (static_cast<int>(m_itemsVisible) - 1);
+#endif
 
             m_topPosition = qMax(m_topPosition, 0);
             break;

To fix this issue without re-breaking #8441, that block of code needs updated to take into account the grid layout option. It has been long enough since I worked on this code, that I will have to re-familiarize myself with it, so I can figure out the correct solution.

comment:4 Changed 3 years ago by Peter Bennett

Here is the real fix

https://github.com/bennettpeter/mythtv/commit/1a650c67cab7c1289f6b3fbbdf7026e9c7128b76

I will test it for a couple of days before committing it to the MythTV repository.

comment:5 Changed 3 years ago by Peter Bennett <pbennett@…>

Resolution: fixed
Status: assignedclosed

In 9a5b4116ae506d4c7f77e88d3b67c368262694ef/mythtv:

Fix scrolling at and of grid style button list.

Fixes #12892

comment:6 Changed 3 years ago by Peter Bennett <pbennett@…>

In 8580a41b71ca24f1900103cc696d246cbac8a769/mythtv:

Fix scrolling at and of grid style button list.

Fixes #12892

(cherry picked from commit 9a5b4116ae506d4c7f77e88d3b67c368262694ef)

comment:7 Changed 18 months ago by Peter Bennett

Owner: changed from Peter Bennett to Peter Bennett
Note: See TracTickets for help on using tickets.