Recordings screen update issue on some themes

[Kenni Lund <kenni@…>]

Updated description:
In Metallurgy, Mythbuntu and Childish, when you have more recordings of one program than what can be shown in one screen, deleting the oldest recording should move the selection bar one up and empty the line containing the old recording. Metallurgy illustrates how this should work:
​http://www.postimage.org/image.php?v=Pqdluz9

However, when you do this on the Mythbuntu or Childish theme, you'll get the recording from the other end of the list, instead of an empty line:
​http://www.postimage.org/image.php?v=Pqdl5CJ

But this line should just be empty, as the line doesn't exist. You cannot select it, as illustrated by the arrows on the right side of the screen, in the Mythbuntu screenshot above. If you click down once, the selection will just jump to the top of the list, just like in Metallurgy.

Confirmed on trunk r26203

[Kenni Lund <kenni@…>]

This is btw. on 0.23-fixes r24486:

$ mythfrontend --version
Please attach all output as a file in bug reports.
MythTV Version   : 24486M
MythTV Branch    : branches/release-0-23-fixes
Network Protocol : 56
Library API      : 0.23.20100429-1
QT Version       : 4.6.2
Options compiled in:
 linux release using_oss using_alsa using_backend using_dvb using_frontend using_hdpvr using_iptv using_lirc using_mheg using_opengl_video using_opengl_vsync using_qtdbus using_qtwebkit using_v4l using_x11 using_xrandr using_xv using_bindings_perl using_bindings_python using_opengl using_vdpau using_ffmpeg_threads using_live using_mheg

[robertm]

Don't see anything to indicate this would be theme related, have you tried in other themes? The button ordering/changing of button orders shouldn't depend on theme at all.

[robertm]

It was pointed out to me that you are asking about the wrap behavior-- this is as the themer intended it-- he wants the list to wrap when full. As such, there is no bug to speak of here-- if this is unclear or we can answer questions about it, please follow up on the users list. You may also be interested in reading up on "wrapstyle" here:

http://www.mythtv.org/wiki/MythUI_Theme_Development#The_buttonlist_widget

[cpinkham]

Here's a copy of some instructions for reproducing the bug. I also posted to the mailing list thread about this.

1) Set your sort order to "Sort all sub-titles/multi-titles Ascending".

2) Go back to Watch Recordings and scroll to a title that has more items than will fit on the right hand side of the screen.

3) Cursor Right to select the subtitle list.

4) Scroll down to the bottom-most (ie, newest) recording.

5) Delete it.

6) Watch the focus/selector bar move up one item and the very top (ie, oldest) item in the list magically appear at the bottom of the list.

7) Try to scroll down to that oldest item now visible at the bottom of the list.

8) Watch the list redraw and focus move to the top of the list and the oldest item.

[Kenni Lund [kenni AT kelu d0t dk] <kenni@…>]

Just to be clear, this is not a MythBuntu? theme specific issue, Childish is affected as well (trunk r26135).

I've just noticed that the theme Metallurgy is functionally equal to MythBuntu? and Childish in that menu, but Metallurgy shows exactly how it *should* work, eg. on deletion it moves the selection bar one line up and replaces the deleted recording with an empty line (instead of replacing it with a recording from the other end of the recording list).

[Kenni Lund [kenni a kelu dot dk]]

stuartm, assigning to you, since you committed a new wrapstyle the other day and seems to be the developer who works the most in this area.

[stuartm]

Kenni, which painter are you using?

[anonymous]

I have also noticed this bug. I am using OpenGL.

[Kenni Lund [kenni a kelu dot dk]]

stuartm, Qt or OpenGL, I'm seeing the issue with both of them.

[John Poet <jpoet@…>]

In 3342f6a3067c7ec5583dad73056f65f4a8f55f31/mythtv:

MythUIButtonList::CalculateButtonPositions?: Make sure m_topPosition is
adjusted if last item is delete ScrollFree? mode.

Fixes #8441

[Mark Spieth]

only move topselected if bottom was displayed