Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12998 closed Patch - Bug Fix (fixed)

Fix compiler warnings in 0.28

Reported by: David Hampton <mythtv@…> Owned by: Karl Dietz <dekarl@…>
Priority: minor Milestone: 0.28.2
Component: MythTV - General Version: 0.28.1
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Compiling 0.28 generates some warning messages. These patches fix the simple warnings.

Attachments (3)

0001-Fix-compiler-Wnonnull-compare-error-message.patch (603 bytes) - added by David Hampton <mythtv@…> 4 years ago.
Remove comparison that will always fail.
0002-Fix-compiler-Wmisleading-indentation-warning-message.patch (3.3 KB) - added by David Hampton <mythtv@…> 4 years ago.
Fix for misleading indentation.
0003-Fix-compiler-Wmisleading-indentation-warning-message.patch (691 bytes) - added by David Hampton <mythtv@…> 4 years ago.
Fix for misleading indentation.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by David Hampton <mythtv@…>

Remove comparison that will always fail.

Changed 4 years ago by David Hampton <mythtv@…>

Fix for misleading indentation.

Changed 4 years ago by David Hampton <mythtv@…>

Fix for misleading indentation.

comment:1 Changed 4 years ago by Peter Bennett

My preference would be to fix these in trunk only. fixes/0.28 will be retired in due course, and these are not bugs that would impact anybody.

comment:2 Changed 4 years ago by Karl Dietz <dekarl@…>

Owner: set to Karl Dietz <dekarl@…>
Resolution: fixed
Status: newclosed

In fc737ffc45fdefd5671568ae0c959e777fd5ffbe/mythtv:

Fix for misleading indentation in greek EIT fixups.

Patch from David Hampton
Already fixed in master with f3ce2b3a

Fixes #12998

comment:3 Changed 4 years ago by Karl Egly

Thanks for the patch. Lets concentrate on master, there's enough to do there. (and fixes/29.0 is around the corner)

Note: See TracTickets for help on using tickets.