Opened 7 years ago
Closed 7 years ago
Last modified 7 years ago
#13265 closed Bug Report - General (fixed)
Lost S/N, BER on OSD DVB signal monitor
| Reported by: | warpme | Owned by: | jpoet |
|---|---|---|---|
| Priority: | minor | Milestone: | 30.0 |
| Component: | MythTV - Recording | Version: | Master Head |
| Severity: | medium | Keywords: | DVB signal monitor, OSD |
| Cc: | Ticket locked: | no |
Description
commit ed85b14 causing LiveTV DVB signal monitor OSD shows only signal strength. S/N and BER parameters are not shown anymore. Reverting this commit brings back DVB OSD signal monitor with signal, SN and BER. tested on current master.
Attachments (1)
Change History (8)
comment:1 Changed 7 years ago by
| Milestone: | needs_triage → 30.0 |
|---|
comment:2 Changed 7 years ago by
Changed 7 years ago by
| Attachment: | 0014-ticket13265-fix-signalmonitor-SN-BER-not-visible.patch added |
|---|
Fix params list in signalmonitor.cpp[h]
comment:3 Changed 7 years ago by
| Owner: | changed from JYA to jpoet |
|---|---|
| Status: | new → accepted |
comment:4 Changed 7 years ago by
| Resolution: | → Fixed |
|---|---|
| Status: | accepted → closed |
Note: See
TracTickets for help on using
tickets.
Inspecting related code shows probable typo in signalmonitor.cpp[h] code.
Namely: ed85b14 adds in all signalmonitor methods a bool _release_stream param as 3rd param. But in signalmonitor.cpp line226 this variable is declared as 4th param. The same in signalmonitor.h line121.
This may explain loss of SN/BER in OSD as now signalmonitor flags are wrongly set to _release_stream variable value....
Attached patch fixes params order in signalmonitor.cpp[h] and restores S/N, BER in OSD for me.