Opened 18 months ago

Closed 12 months ago

Last modified 11 months ago

#13265 closed Bug Report - General (fixed)

Lost S/N, BER on OSD DVB signal monitor

Reported by: warpme Owned by: jpoet
Priority: minor Milestone: 30.0
Component: MythTV - Recording Version: Master Head
Severity: medium Keywords: DVB signal monitor, OSD
Cc: Ticket locked: no

Description

commit ed85b14 causing LiveTV DVB signal monitor OSD shows only signal strength. S/N and BER parameters are not shown anymore. Reverting this commit brings back DVB OSD signal monitor with signal, SN and BER. tested on current master.

Attachments (1)

0014-ticket13265-fix-signalmonitor-SN-BER-not-visible.patch (1.6 KB) - added by warpme 12 months ago.
Fix params list in signalmonitor.cpp[h]

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 months ago by Stuart Auchterlonie

Milestone: needs_triage30.0

comment:2 Changed 12 months ago by warpme

Inspecting related code shows probable typo in signalmonitor.cpp[h] code.

Namely: ed85b14 adds in all signalmonitor methods a bool _release_stream param as 3rd param. But in signalmonitor.cpp line226 this variable is declared as 4th param. The same in signalmonitor.h line121.

This may explain loss of SN/BER in OSD as now signalmonitor flags are wrongly set to _release_stream variable value....

Attached patch fixes params order in signalmonitor.cpp[h] and restores S/N, BER in OSD for me.

Changed 12 months ago by warpme

Fix params list in signalmonitor.cpp[h]

comment:3 Changed 12 months ago by jpoet

Owner: changed from JYA to jpoet
Status: newaccepted

comment:4 Changed 12 months ago by David Hampton

Resolution: Fixed
Status: acceptedclosed

comment:5 Changed 11 months ago by Warpme <warpme@…>

Resolution: Fixedfixed

In e60f71bd0f/mythtv:

Correct the order of arguments in calls to the SignalMonitor? constructor.

Fixes #13265

Signed-off-by: David Hampton <mythtv@…>

comment:6 Changed 11 months ago by Warpme <warpme@…>

In e60f71bd0f/mythtv:

Correct the order of arguments in calls to the SignalMonitor? constructor.

Fixes #13265

Signed-off-by: David Hampton <mythtv@…>

comment:7 Changed 11 months ago by Warpme <warpme@…>

In e60f71bd0f/mythtv:

Correct the order of arguments in calls to the SignalMonitor? constructor.

Fixes #13265

Signed-off-by: David Hampton <mythtv@…>

Note: See TracTickets for help on using tickets.