Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#13361 closed Patch - Bug Fix (fixed)

ChannelUtil::SetVisible function declaration unclear

Reported by: Klaas de Waal Owned by: Klaas de Waal
Priority: minor Milestone: 31.0
Component: MythTV - Channel Scanner Version: Master Head
Severity: low Keywords: DVB channel visible
Cc: stuarta@… Ticket locked: no

Description

The function SetVisible? in ChannelUtil?.cpp is defined as follows: 

bool ChannelUtil::SetVisible(uint channel_id, bool visible)

The implementation sets the channel visible when the second parameter is true.

However, the declaration of SetVisible? in ChannelUtil?.h is as follows: 

   static bool    SetVisible(uint channel_id, bool hidden);

This does suggest that when the second parameter is "true" the channel is hidden, i.e. not visible. The attached patch changes "bool hidden" to "bool visible" so that the declaration does match the implementation.

Attachments (1)

20181219_channelutil-setvisible.patch​ (506 bytes) - added by Klaas de Waal 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Klaas de Waal

Attachment: 20181219_channelutil-setvisible.patch​ added

comment:1 Changed 6 years ago by Klaas de Waal

Owner: set to Klaas de Waal
Status: new → accepted

comment:2 Changed 6 years ago by Klaas de Waal

Resolution: → Fixed
Status: accepted → closed

In commit 670b9ea

Fixes #13361 - ChannelUtil::SetVisible? function declaration unclear

Signed-off-by: Klaas de Waal <mythtv@…>

comment:3 Changed 6 years ago by Klaas de Waal <mythtv@…>

Resolution: Fixed → fixed

In 670b9ea14/mythtv:

Fixes #13361 - ChannelUtil::SetVisible? function declaration unclear

Signed-off-by: Klaas de Waal <mythtv@…>

comment:4 Changed 6 years ago by Stuart Auchterlonie

Milestone: needs_triage → 31.0
Note: See TracTickets for help on using tickets.