Opened 5 years ago

Closed 5 years ago

#13362 closed Patch - Feature (fixed)

Drop variant of MythCoreContext::GenMythURL which takes port as a QString

Reported by: ijc Owned by: David Hampton
Priority: minor Milestone: 31.0
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

There were two places making use of this, but in both cases they were just assigning an integer port to a QString, causing it to be automatically converted to a string. Correcting the types of those variables avoids this.

This is related to #13315, the very first small step towards using a QUrl in this interface, by reducing the API surface.

Attachments (1)

0001-Drop-variant-of-MythCoreContext-GenMythURL-which-tak.patch​ (3.3 KB) - added by ijc 5 years ago.

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by ijc

Attachment: 0001-Drop-variant-of-MythCoreContext-GenMythURL-which-tak.patch​ added

comment:1 Changed 5 years ago by David Hampton

Milestone: needs_triage → 31.0
Owner: set to David Hampton
Status: new → assigned

comment:2 Changed 5 years ago by Ian Campbell <ijc@…>

Resolution: → fixed
Status: assigned → closed

In 4a2be05d2d/mythtv:

Drop variant of MythCoreContext::GenMythURL which takes port as a QString.

Fixes #13362.

Signed-off-by: David Hampton <mythtv@…>

Note: See TracTickets for help on using tickets.