Opened 6 years ago

Closed 6 years ago

#13363 closed Patch - Feature (fixed)

(Very) Minor improvements to StringList protocol encoding debug

Reported by: ijc Owned by: David Hampton
Priority: minor Milestone: 31.0
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Two incredibly small tweaks made during my debug of #13315...

  • Don't unnecessarily construct the QByteArray payload in ReadStringListReal(), it is only used for the debug log so move the construction inside the condition.
  • Increase the length of the log of the encoded QStringList in WriteStringListReal and ReadStringListReal to 127 (from 85) in the non-debug case. I found 85 wasn't quite enough to see what was going on for some commands when using real world path lengths in the command arguments. (127 is entirely arbitrary, I had been using 255 in my local debug but that seemed quite a lot so I settled in 127 for this submission...)

Attachments (2)

0001-ReadStringListReal-move-construction-of-QByteArray-u.patch​ (1.3 KB) - added by ijc 6 years ago.
0002-Read-WriteStringList-Increase-length-of-debug-output.patch​ (1.8 KB) - added by ijc 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by ijc

Attachment: 0001-ReadStringListReal-move-construction-of-QByteArray-u.patch​ added

Changed 6 years ago by ijc

Attachment: 0002-Read-WriteStringList-Increase-length-of-debug-output.patch​ added

comment:1 Changed 6 years ago by David Hampton

Owner: set to David Hampton
Status: new → assigned

comment:2 Changed 6 years ago by David Hampton

Milestone: needs_triage → 30.1

comment:3 Changed 6 years ago by David Hampton

Milestone: 30.1 → 31.0

comment:4 Changed 6 years ago by Ian Campbell <ijc@…>

Resolution: → fixed
Status: assigned → closed

In 72f71a7e1/mythtv:

Minor improvements to StringList? protocol encoding debug.

Fixes #13363.

Signed-off-by: David Hampton <mythtv@…>

Note: See TracTickets for help on using tickets.