Opened 5 years ago

Closed 5 years ago

#13364 closed Patch - Bug Fix (fixed)

mythfrontend segfault

Reported by: Klaas de Waal Owned by: David Hampton
Priority: major Milestone: 30.0
Component: MythTV - General Version: Master Head
Severity: high Keywords:
Cc: David, Hampton Ticket locked: no

Description

mythfrontend segfaults when you select "Manage Recordings" then "Recording Rules".

This is caused by commit 17d978723, 13 december, David Hampton, "Use naturalCompare in more places instead of a simple '<' comparison."

In some places the "< 0" is omitted and then the value of naturalCompare is returned instead of a boolean value. This apparently causes the sort to fail.

The patch adds the "< 0" comparison where it is missing in files programrecpriority.cpp and proglist.cpp.

Attachments (1)

20181226_naturalCompareLT.patch​ (6.4 KB) - added by Klaas de Waal 5 years ago.

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by Klaas de Waal

Attachment: 20181226_naturalCompareLT.patch​ added

comment:1 Changed 5 years ago by David Hampton

Milestone: needs_triage → 30.0
Owner: set to David Hampton
Status: new → accepted
Version: Unspecified → Master Head

comment:2 Changed 5 years ago by Klass De Waal <klaas.de.waal@…>

Resolution: → fixed
Status: accepted → closed

In 6c76d1767/mythtv:

Fix mythfrontend segfaults in "Recording Rules".

There are a number of places where the result of naturalCompare (which
returns -1,0,1) are implicitly converted to a boolean and returned to
the caller. These need to be explicitly compared to 0, and the result
of that comparison returned to the caller.

Fixes #13364

Signed-off-by: David Hampton <mythtv@…>

Note: See TracTickets for help on using tickets.