Opened 4 years ago

Closed 2 years ago

#13626 closed Patch - Bug Fix (Trac EOL)

Allow the image viewer to handle symlinks

Reported by: jwhite66 Owned by:
Priority: minor Milestone: needs_triage
Component: MythTV - General Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

A valuable use case for me, personally, is to have my images organized stored based on how they were acquired, but then write scripts to organize them more systematically, with symlinks back to the source files.

The current code prevents that by ignoring symbolic links. That choice has existed since commit f3ba1b37c4c6db470bf21dcb54f77cd949777f63 in 2013 which originated this function afaict. It's not clear to me if ignoring symlinks solves a problem or was just chosen arbitrarily. The videos viewer works fine with symlinks, so this makes the gallery more in step with video files.

The change is trivial, and appears to work in my testing. A pull request has been created for this as well.

Change History (3)

comment:1 Changed 4 years ago by Klaas de Waal

Please add your changes as a patch to this ticket.

comment:2 Changed 3 years ago by Klaas de Waal

The filter option setting appears to have moved to libs/libmythmetadata/imagemanager.cpp:320-323 in today's master:

    // Apply filters to only detect image files
    m_dirFilter.setNameFilters(glob);
    m_dirFilter.setFilter(QDir::AllDirs | QDir::Files | QDir::Readable |
                          QDir::NoDotAndDotDot | QDir::NoSymLinks);

Removing the QDir::NoSymLinks? option is indeed trivial and is worth a try.

comment:3 Changed 2 years ago by Stuart Auchterlonie

Resolution: Trac EOL
Status: newclosed

We have moved all bug tracking to github [1]

If you continue to have this issue, please open a new issue at github, referencing this ticket.

[1] - https://github.com/MythTV/mythtv/issues

Note: See TracTickets for help on using tickets.