Opened 5 years ago
Closed 5 years ago
Last modified 5 years ago
#13633 closed Patch - Feature (fixed)
Improve mythfilldatabase XMLTV logging
| Reported by: | Gary Buhrmaster | Owned by: | David Hampton |
|---|---|---|---|
| Priority: | minor | Milestone: | 31.1 |
| Component: | MythTV - Mythfilldatabase | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Improve mythfilldatabase XMLTV logging
The intent of these patches is to improve logging, especially for those converting from the legacy DataDirect? service to the Schedules Direct XMLTV service. It is hoped that this patch set be backported to fixes/31. The changes have been separated into smaller pieces so that the designated SME can more appropriately review the codes.
The changes are:
- Add what appears to be a missing logging message for the interrupted grabber case.
- Remove a LOC identifier that is not used elsewhere for LOG_ERR messages in mythfilldatabase.
- Invoke the running of the grabber such that the output is actually captured and logged (the code implies (via header/trailer separators) that at some time in the past the output was made available in the logs, but it has not been so for some time).
- Change the loglevel in programdata to be the same as EIT updates (i.e. debug). This also allows a run of "mythfilldatabase --verbose general,xmltv" to not needlessly include messages about adding/deleting actual programs (i.e. making the usage easier to review), but just include the XMLTV logging that likely matters for the average use case.
FWIW, I initially used the new MythSystem? rather than MythSystemLegacy? for the grabber invokation, but the rabbit hole for proper implementation included implementing a TODO in MythSystem?, and since it was a larger update, would likely not be appropriate to backport. I'll look at the TODO in MythSystem? and converting mythfilldatabase at some later time.
Operational status: It is in the "works for me" phase (I am using the entire set of patches with my own builds of MythTV).
Patches will be attached.
Attachments (4)
Change History (8)
Changed 5 years ago by
| Attachment: | 0001-add-missing-log-message-when-grabber-interrupted.patch added |
|---|
Changed 5 years ago by
| Attachment: | 0002-eliminate-extranous-LOC-in-logging.patch added |
|---|
eliminate-extranous-LOC-in-logging
Changed 5 years ago by
| Attachment: | 0003-Enable-output-from-the-grabber-to-be-logged.patch added |
|---|
Enable-output-from-the-grabber-to-be-logged
Changed 5 years ago by
| Attachment: | 0004-Update-XMLTV-loglevel-in-programdata.patch added |
|---|
Update-XMLTV-loglevel-in-programdata
comment:1 Changed 5 years ago by
| Owner: | set to David Hampton |
|---|---|
| Status: | new → assigned |
comment:2 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:4 Changed 5 years ago by
| Milestone: | needs_triage → 31.1 |
|---|
add-missing-log-message-when-grabber-interrupted