Opened 8 weeks ago

Closed 2 weeks ago

Last modified 10 days ago

#13633 closed Patch - Feature (fixed)

Improve mythfilldatabase XMLTV logging

Reported by: Gary Buhrmaster Owned by: David Hampton
Priority: minor Milestone: 31.1
Component: MythTV - Mythfilldatabase Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Improve mythfilldatabase XMLTV logging

The intent of these patches is to improve logging, especially for those converting from the legacy DataDirect? service to the Schedules Direct XMLTV service. It is hoped that this patch set be backported to fixes/31. The changes have been separated into smaller pieces so that the designated SME can more appropriately review the codes.

The changes are:

  • Add what appears to be a missing logging message for the interrupted grabber case.
  • Remove a LOC identifier that is not used elsewhere for LOG_ERR messages in mythfilldatabase.
  • Invoke the running of the grabber such that the output is actually captured and logged (the code implies (via header/trailer separators) that at some time in the past the output was made available in the logs, but it has not been so for some time).
  • Change the loglevel in programdata to be the same as EIT updates (i.e. debug).  This also allows a run of "mythfilldatabase --verbose general,xmltv" to not needlessly include messages about adding/deleting actual programs (i.e. making the usage easier to review), but just include the XMLTV logging that likely matters for the average use case.

FWIW, I initially used the new MythSystem? rather than MythSystemLegacy? for the grabber invokation, but the rabbit hole for proper implementation included implementing a TODO in MythSystem?, and since it was a larger update, would likely not be appropriate to backport. I'll look at the TODO in MythSystem? and converting mythfilldatabase at some later time.

Operational status:  It is in the "works for me" phase (I am using the entire set of patches with my own builds of MythTV).

Patches will be attached.

Attachments (4)

0001-add-missing-log-message-when-grabber-interrupted.patch (936 bytes) - added by Gary Buhrmaster 8 weeks ago.
add-missing-log-message-when-grabber-interrupted
0002-eliminate-extranous-LOC-in-logging.patch (1.1 KB) - added by Gary Buhrmaster 8 weeks ago.
eliminate-extranous-LOC-in-logging
0003-Enable-output-from-the-grabber-to-be-logged.patch (1.6 KB) - added by Gary Buhrmaster 8 weeks ago.
Enable-output-from-the-grabber-to-be-logged
0004-Update-XMLTV-loglevel-in-programdata.patch (2.8 KB) - added by Gary Buhrmaster 8 weeks ago.
Update-XMLTV-loglevel-in-programdata

Download all attachments as: .zip

Change History (8)

Changed 8 weeks ago by Gary Buhrmaster

add-missing-log-message-when-grabber-interrupted

Changed 8 weeks ago by Gary Buhrmaster

eliminate-extranous-LOC-in-logging

Changed 8 weeks ago by Gary Buhrmaster

Enable-output-from-the-grabber-to-be-logged

Changed 8 weeks ago by Gary Buhrmaster

Update-XMLTV-loglevel-in-programdata

comment:1 Changed 8 weeks ago by David Hampton

Owner: set to David Hampton
Status: newassigned

comment:2 Changed 2 weeks ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: assignedclosed

In 8602e97877/mythtv:

Update XMLTV loglevel in programdata

Change the loglevel in programdata to be the same as
EIT updates for the equivalent changes (i.e. debug).
This allows a run of mythfilldatabase with the options
of --verbose general,xmltv with the default loglevel
of info to not blather on about the expected case of
adding, deleting, updating programs (i.e. making the
usage easier to review), but just include the XMLTV
logging that likely matters for the average use case.

Last of four patches. Fixes #13633.

Signed-off-by: David Hampton <mythtv@…>
(cherry picked from commit 6e61aa988fe1cbc260798d5be53c496f66b04f4f)

comment:3 Changed 10 days ago by Gary Buhrmaster <gary.buhrmaster@…>

In 8602e97877/mythtv:

Update XMLTV loglevel in programdata

Change the loglevel in programdata to be the same as
EIT updates for the equivalent changes (i.e. debug).
This allows a run of mythfilldatabase with the options
of --verbose general,xmltv with the default loglevel
of info to not blather on about the expected case of
adding, deleting, updating programs (i.e. making the
usage easier to review), but just include the XMLTV
logging that likely matters for the average use case.

Last of four patches. Fixes #13633.

Signed-off-by: David Hampton <mythtv@…>
(cherry picked from commit 6e61aa988fe1cbc260798d5be53c496f66b04f4f)

comment:4 Changed 10 days ago by Stuart Auchterlonie

Milestone: needs_triage31.1
Note: See TracTickets for help on using tickets.