Opened 14 years ago

Closed 14 years ago

#1802 closed defect (fixed)

mythgallery does not set the startdir correctly when using removable media

Reported by: leo+nospam at weppelman.net Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythgallery Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When mythgallery starts due to insertion of a dvd with pictures, it is nearly impossible to leave the plugin. This stems from the fact that you leave the plugin by ascending 'above' de base directory. Since the base directory (m_galleryDir) is not set to de mountpoint of the removable media, leaving the plugin is nearly impossible.

Attachments (1)

gallery.diff (403 bytes) - added by leo+nospam at weppelman.net 14 years ago.

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by leo+nospam at weppelman.net

Attachment: gallery.diff added

comment:1 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [10030]) Close #1802 by applying patch to set the gallery path when starting from a cd/dvd.

comment:2 Changed 14 years ago by Aaron McCarthy <mccarthy.aaron@…>

Resolution: fixed
Status: closedreopened

The patch that was applied to fix this ticket is incorrect. m_galleryDir should always be set to the directory define in the gallery settings. There is logic in the ESCAPE key handler (iconview.cpp:596) to test if the current directory is the mount point of the inserted media. If that is not working correctly then that is where the fix needs to be.

The way I designed this code to work is that ascending above the mount point of the removable media would take you to the "select removable media" menu, ascending past that would take you back to m_galleryDir. From there it is possible to exit the gallery plugin. If this is too tedious and it is desired to exit the gallery directly from the mount point of a removable media then should be removing the logic, or at least conditionally executing it based on a setting around iconview.cpp:596.

comment:3 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: reopenedclosed

Trac is not a discussion forum.

comment:4 Changed 14 years ago by devel@…

Resolution: fixed
Status: closedreopened

This breaks mythgallery for me. With a DVD-video in the drive I can no longer exit the gallery. MythTV starts up and "handles" the dvd using mythgallery.

  1. I get an iconview showing audio_ts and video_ts. 2. When I press escape i get Gallery and [DVD_NAME]. This continues in an endless loop and there is no way of exiting the gallery.

Before this patch was applied everything worked correctly.

comment:5 Changed 14 years ago by danielk

Resolution: fixed
Status: reopenedclosed

trac is not a support forum.

Note: See TracTickets for help on using tickets.