Configuring number of channels causes channel names to be missaligned with program information.

[anonymous]

If I change the configuration of the guide to show six channels rather than the default five, the channel names/icons no longer line up with the program information. See attached screenshots for before and after.

[lyricnz@…]

Screenshot of program guide with missaligned channels/programs

[lyricnz@…]

Screenshot of program guide with missaligned channels/programs

[anonymous]

This may be an off-by-one error : my configuration actually has SIX channels configured.

​http://svn.mythtv.org/trac/browser/trunk/mythtv/libs/libmythtv/guidegrid.cpp#L247 247 maxchannel = max((int)m_channelInfos.size() - 1, 0); 248 setStartChannel((int)(m_currentStartChannel) - 249 (int)(desiredDisplayChans / 2)); 250 if (DISPLAY_CHANS > maxchannel) 251 DISPLAY_CHANS = maxchannel

maxchannel look like a zero-based index, and DISPLAY_CHANS is a one-based number. Surely the "if" clause is off-by-one?

[anonymous]

(Repost of previous comment with proper formatting. Sorry)

This may be an off-by-one error : my configuration actually has SIX channels configured.

​http://svn.mythtv.org/trac/browser/trunk/mythtv/libs/libmythtv/guidegrid.cpp

247 	    maxchannel = max((int)m_channelInfos.size() - 1, 0);
248 	    setStartChannel((int)(m_currentStartChannel) -
249 	                    (int)(desiredDisplayChans / 2));
250 	    if (DISPLAY_CHANS > maxchannel)
251 	        DISPLAY_CHANS = maxchannel;

maxchannel look like a zero-based index, and DISPLAY_CHANS is a one-based number. Surely the "if" clause is off-by-one?

[dscoular@…]

Hi Llyric, I've verified that this is a bug. I modified line 251 from:

    if (DISPLAY_CHANS > maxchannel)
        DISPLAY_CHANS = maxchannel;

to:

    if (DISPLAY_CHANS > maxchannel + 1) // DUG FIXME
        DISPLAY_CHANS = maxchannel;

And it fixes the issue for me. However, there a number of these exact same if statements through this file and I suspect they should all be changed to the above.

Cheers,

Doug

[lyricnz@…]

Previous attachment is by dscoular@…, and is against 0.19-fixes svn revision 9953.

I am unable to verify this myself right now, as I have other unrelated issues with myth-svn. Will apply this patch to my 0.19 build tonight, and see how it goes.

[lyricnz@…]

Yup, good.patch appears to fix the problem for me, see following screenshot.

[lyricnz@…]

Screenshot of guide after applying good.patch

[Isaac Richards]

Fixed in [10026].

[lyricnz@…]

Please apply this fix to 0.19-fixes. Thanks!